Skip to content

npm audit fix force - #7

Open
RiccardiLd wants to merge 3 commits into
developfrom
bugfix/npm-audit-fix
Open

npm audit fix force#7
RiccardiLd wants to merge 3 commits into
developfrom
bugfix/npm-audit-fix

Conversation

@RiccardiLd

Copy link
Copy Markdown

No description provided.

@RiccardiLd RiccardiLd added the bug label Jul 2, 2018
@RiccardiLd RiccardiLd self-assigned this Jul 2, 2018

@mrister mrister left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to add package-lock.json to .gitignore

@jkernech jkernech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @mrister, please update the PR

@RiccardiLd
RiccardiLd requested review from jkernech and mrister July 3, 2018 08:59
@RiccardiLd

Copy link
Copy Markdown
Author

Is there anything I have to do here for these checks to pass @jkernech ?

@jkernech

jkernech commented Aug 3, 2018

Copy link
Copy Markdown
Contributor

@RiccardiLd as seen together, integration of CircleCI was failing without much explanation, we had to remove the project from CircleCI and add it again to make the integration work 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants