Fixture/update config files - #7
Open
steven-heng wants to merge 21 commits into
Open
Conversation
jkernech
suggested changes
Aug 20, 2018
| @sonar-scanner-2.8/bin/sonar-scanner -e -Dsonar.analysis.mode=preview -Dsonar.github.pullRequest=${shell basename $(CI_PULL_REQUEST)} -Dsonar.github.repository=$(REPO_SLUG) -Dsonar.github.oauth=$(GITHUB_TOKEN) -Dsonar.login=$(SONAR_LOGIN) -Dsonar.password=$(SONAR_PASS) -Dsonar.host.url=$(SONAR_HOST_URL) | ||
| endif | ||
| ifeq ($(CIRCLE_BRANCH),develop) | ||
| @sonar-scanner-2.8/bin/sonar-runner -e -Dsonar.analysis.mode=publish -Dsonar.host.url=$(SONAR_HOST_URL) -Dsonar.login=$(SONAR_LOGIN) -Dsonar.password=$(SONAR_PASS) |
Contributor
There was a problem hiding this comment.
Use sonar-scanner here, sonar-runner is deprecated
mrister
approved these changes
Aug 23, 2018
| # Coverage directory used by tools like istanbul | ||
| # Coverage directory used by tools like nyc | ||
| coverage | ||
| .sonar/ |
Contributor
There was a problem hiding this comment.
Yes it should be added back
jkernech
suggested changes
Sep 4, 2018
| # Coverage directory used by tools like istanbul | ||
| # Coverage directory used by tools like nyc | ||
| coverage | ||
| .sonar/ |
Contributor
There was a problem hiding this comment.
Yes it should be added back
jkernech
approved these changes
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Npm audit found 0 vulnerabilities
Modify rules command of package.json and Makefile
Add badges to README.md