sv merge updates for BNDs - #1
Open
miller-alexander wants to merge 6 commits into
Open
Conversation
Added functionality for merging BND type events.
dhspence
reviewed
Jun 29, 2022
dhspence
left a comment
dhspence
left a comment
Contributor
There was a problem hiding this comment.
This looks ok to me. The coordinate checking on lines 363-373 looks right to me, although I'm a little confused about slop being used for 2 purposes. Annotating each if statement there with the case could be helpful if it turns out there are bugs or something.
Contributor
|
Go ahead and merge this request. |
Author
|
I co-opted the slop parameter for the CNV merging step as well. I should probably either set a new parameter for that or just fix it at a certain number. Not sure it needs to be tunable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality for BNDs and updated the readme file