Clone Cubes and standalone containers - #24
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adaf6d3254
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert.match(cloneSource, /nextCloneName/); | ||
| assert.match(cloneSource, /cloneCubeDraft/); | ||
| assert.match(cloneSource, /cloneContainerSpec/); | ||
| assert.match(cloneSource, /cubeNetworkName/); | ||
| assert.match(cloneSource, /defaultCubeWorkspacePath/); |
There was a problem hiding this comment.
Invoke these helpers with representative inputs instead of only matching their names in the source. An implementation where nextCloneName always returns an existing name, cloneCubeDraft mutates its argument, or the infrastructure helpers are merely imported but never used satisfies every assertion here, so regressions in every behavior named by this test remain undetected.
Useful? React with 👍 / 👎.
| assert.match(groupsView, /Clone Cube/); | ||
| assert.match(groupsView, /CloneCubeDialog/); | ||
| assert.match(groupsView, /Save Clone/); | ||
| assert.match(groupsView, /readOnly/); |
There was a problem hiding this comment.
Verify the clone dialog's individual configuration controls rather than searching the entire groups-view.tsx file for readOnly. That file already contained an unrelated read-only workspace input before this change, so a clone dialog that leaves all copied runtime/configuration fields editable will still pass this assertion once its name and button labels are added.
Useful? React with 👍 / 👎.
1 participant
TDD scope
The first commits intentionally define failing regressions before implementation.