Skip to content

Phpstan analysis issues #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgtlss merged 2 commits into from
Feb 27, 2026
Merged

Phpstan analysis issues #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd9793
Fix PHPStan analysis issues
cursoragent Feb 27, 2026
7400f62
Merge branch 'cursor/development-environment-setup-8bf3' into cursor/…
dgtlss Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions src/Commands/WardenAuditCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,17 +184,10 @@ protected function runSequentialAudits(bool $isMachineOutput = false): int

protected function processResults(array $allFindings, array $abandonedPackages, bool $hasFailures): int
{
$totalBeforeFilter = count($allFindings);
$severityOption = $this->option('severity');

if ($severityOption && is_string($severityOption)) {
$validLevels = ['low', 'medium', 'high', 'critical'];
if (!in_array($severityOption, $validLevels, true)) {
$this->error(sprintf('Invalid severity level: %s. Valid levels: %s', $severityOption, implode(', ', $validLevels)));
return 2;
}

$allFindings = $this->filterBySeverity($allFindings, $severityOption);
// Apply severity filtering if specified
if ($this->option('severity')) {
$severityOption = $this->option('severity');
$allFindings = $this->filterBySeverity($allFindings, (string) $severityOption);
}

$this->handleAbandonedPackages($abandonedPackages);
Expand Down Expand Up @@ -319,7 +312,9 @@ protected function initializeAuditServices(): array
*/
protected function handleAuditFailure(object $service): void
{
$serviceName = method_exists($service, 'getName') ? $service->getName() : 'Unknown service';
$serviceName = $service instanceof \Dgtlss\Warden\Services\Audits\AbstractAuditService || $service instanceof CustomAuditWrapper
? $service->getName()
: 'Unknown service';
$this->error($serviceName . ' audit failed to run.');
if ($service instanceof ComposerAuditService) {
$findings = $service->getFindings();
Expand Down
3 changes: 2 additions & 1 deletion src/Services/Audits/DebugModeAuditService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,10 @@ private function getInstalledPackages(): array
private function hasExposedTestingRoutes(): bool
{
$routeCollection = \Route::getRoutes();
$routes = iterator_to_array($routeCollection, false);

// Check debugbar routes separately as they're allowed when APP_DEBUG is true
foreach ($routeCollection as $route) {
foreach ($routes as $route) {
$uri = $route->uri();
if (str_starts_with($uri, '_debugbar')) {
// Only flag debugbar routes as exposed if APP_DEBUG is false and there's no protective middleware
Expand Down