Feature/2 logging abstractions - #14
Merged
Merged
Conversation
- add ILogger param (default NullLogger) to both SecretsManagerService constructors - log cache hit/miss, refresh, invalidate, local fallback usage, and fetch/deserialize failures - wire OnRetry into the Polly pipeline for retry-attempt warnings - add ILogger overload to SecretsManagerServiceFactory.Create
The library was referencing 10.x, the latest available when logging support was added. NLog.Extensions.Logging 6.1.4 (used in MvcExample.Infrastructure) resolves to 8.x, so referencing both together in the same dependency graph produced a version conflict. Microsoft.Extensions.Logging.Abstractions' public surface has been stable across 8.x-10.x, so downgrading costs nothing functionally and is the more correct choice regardless of this specific conflict: a library should reference the oldest version that has the APIs it needs, not the newest available at write time, so it imposes the loosest possible constraint on consumers' own dependency graphs.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
ILoggersupport (defaultNullLogger) acrossSecretsManagerServiceandSecretsManagerServiceFactory— cache hit/miss, refresh, invalidate, local fallback usage,retry attempts, and fetch/deserialize failures. Backward-compatible with 0.1.x consumers.
Includes a follow-up fix downgrading
Microsoft.Extensions.Logging.Abstractionsto 8.x toresolve a version conflict with
NLog.Extensions.Loggingin downstream consumers.Closes #2