Improve asset type icon management

[tobmes42]

Problem:
When creating or editing an asset type (AssetsType) via the Web GUI, several limitations existed:

• Uploaded icons were stored under a random 18-character string without a file extension → not recognizable and not reusable.
• Previously uploaded icons could not be reselected (no dropdown for existing icons).
• No magic-byte validation – any file with a .png/.svg extension was accepted.
• With readOnlyRootFilesystem: true in the container, saving the symlink failed with "Read-only file system".
• When no icon was provided for "compromised" and the "Use same icon" checkbox was unchecked, os.path.join(path, None) caused a TypeError, making the asset type list endpoint crash.
• No client-side validation allowed submitting the form without setting both icons (or the checkbox).

Changes:
GUI / User Experience (modal_add_asset_type.html + manage.objects.js):

• Both icon fields ("not compromised" / "compromised") now have a searchable selectpicker dropdown (data-live-search="true") listing all available icons from /iriswebapp/static/assets/img/graph.
• Selecting an existing icon from the dropdown clears the file upload field (and vice versa).
• A checkbox "Use the same icon for compromised as for not compromised" disables the compromised icon fields.
• The uploaded file name is displayed in the .custom-file-label.
• Client-side validation on submit:
• If the checkbox is checked → "not compromised" must have an icon.
• If the checkbox is not checked → both fields must have an icon (upload or selection).
• In update mode, existing icons ("Current:") are taken into account.
• Otherwise a notify_error toast is shown.

Backend / REST API (manage_assets_type_routes.py):

• New helper _resolve_existing_icon(name): checks if an icon name exists in the graph directory and returns it.
• During icon resolution: first checks if a file was uploaded, then if an existing icon was selected from the dropdown. If the checkbox is set, fpath_c = fpath_nc.
• list_assets is now guarded against None icon values (returns empty string instead of os.path.join(…, None)), preventing the DataTable crash.
• load_store_icon now has a None-guard if not file_storage or not file_storage.filename: return None to prevent the crash when the checkbox is set.

Icon Storage (marshables.py):

• store_icon now uses the original file name (sanitized via secure_filename) instead of a random string.
• On name collision, a numeric suffix is appended (file.png, file_1.png, …).
• The file extension is preserved (.png/.svg) – uploaded icons are automatically recognized in the icon listing.
• New validation function _is_valid_icon_content(): checks magic bytes.
• PNG: signature \x89PNG\r\n\x1a\n
• SVG: declaration <?xml or <svg (UTF-8, BOM-tolerant)
• The stream is rewound after checking so file.save() can still write the full file.

Icon Listing (manage_assets_type_routes.py – Pages):

• _list_graph_icons() now also detects custom uploaded icons (symlinks pointing into the asset store path) in addition to files with .png/.svg extension.
• The list is sorted alphabetically and passed to both the add and update modals.

Affected files:

• source/app/schema/marshables.py
• source/app/blueprints/rest/manage/manage_assets_type_routes.py
• source/app/blueprints/pages/manage/manage_assets_type_routes.py
• source/app/blueprints/pages/manage/templates/modal_add_asset_type.html
• ui/src/pages/manage.objects.js

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• api_*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 850d3eef-0350-4d10-80b9-270072488361

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}