Skip to content

fix(pic): include request path in PocketIC server error messages (#70) #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosxenakis merged 3 commits into from
Mar 11, 2026
Merged

fix(pic): include request path in PocketIC server error messages (#70) #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a54f2f
fix(pic): include request path in PocketIC server error messages (#70)
Mar 11, 2026
a6c0a21
fix(pic): include request path in server error messages
Mar 11, 2026
7263ed2
fix(pic): lint
Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/pic/src/http2-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export class Http2Client {

// server encountered an error, fail immediately
if ('message' in resBody) {
throw new ServerError(resBody.message);
throw new ServerError(`${resBody.message} (${init.path})`);
}

// the server has started processing or is busy
Expand Down Expand Up @@ -149,7 +149,7 @@ export class Http2Client {

// server encountered an error, fail immediately
if ('message' in resBody) {
throw new ServerError(resBody.message);
throw new ServerError(`${resBody.message} (${init.path})`);
}
Comment thread
nikosxenakis marked this conversation as resolved.

// the server has started processing or is busy
Expand Down
14 changes: 13 additions & 1 deletion packages/pic/tests/src/util/http2-client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('Http2Client', () => {
const err = await client.jsonGet({ path: '/test' }).catch(e => e);

expect(err).toBeInstanceOf(ServerError);
expect(err.serverMessage).toBe('SettingTimeIntoPast');
expect(err.serverMessage).toBe('SettingTimeIntoPast (/test)');
expect(fetchMock).toHaveBeenCalledTimes(1);
});

Expand Down Expand Up @@ -134,6 +134,18 @@ describe('Http2Client', () => {
expect(fetchMock).toHaveBeenCalledTimes(2);
});

it('should throw ServerError immediately on error response', async () => {
fetchMock.mockResolvedValue(
jsonResponse({ message: 'InstanceNotFound' }),
);

const err = await client.jsonPost({ path: '/test' }).catch(e => e);

expect(err).toBeInstanceOf(ServerError);
expect(err.serverMessage).toBe('InstanceNotFound (/test)');
expect(fetchMock).toHaveBeenCalledTimes(1);
});

it('should poll read_graph on 202 until the result is ready', async () => {
fetchMock
.mockResolvedValueOnce(
Expand Down
Loading