feat: revert and add rounds as request parameter of awaitCall - #223
Merged
Conversation
Contributor
|
LGTM, as I mentioned to @raymondk - both solutions seem fine to me. |
raymondk
approved these changes
Jan 7, 2026
raymondk
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #220 introduced a new
roundsoption forawaitCallby duplicating the existing function with a new function calledawaitCallWithRounds. I randomly noticed the PR and discussed it with @raymondk, as it felt like neither an idiomatic solution nor particularly ergonomic, since it could have been resolved by simply adding the new optional parameter as... an optional parameter. Which is what this PR does.Changes
awaitCallWithRounds(not a breaking change, as this was not yet shipped)roundstoAwaitCanisterCallRequestparameterNotes
No tests, as none were provided in the original PR.
No documentation, as none was provided in the original PR and none exists in the codebase for the related module.