build: bump @icp-sdk/core v5 - #221
Merged
Merged
Conversation
error: lockfile had changes, but lockfile is frozen
Contributor
Author
|
Example of conflict AgentJS v4 vs v5: https://github.com/junobuild/juno/actions/runs/20714882020/job/59463849158?pr=2463 |
raymondk
approved these changes
Jan 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 5, 2026
raymondk
enabled auto-merge
January 5, 2026 19:50
Contributor
Author
|
Is the test suite flaky or which changes fixed the tests failure https://github.com/dfinity/pic-js/actions/runs/20715931311/job/59466991938?pr=221? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Developer using pic-js cannot cleanly upgrade their project to
@icp-sdk/core@5because pic requires v4. As a result, devs ends withpackage-lock.jsonthat references both, which in turns is a conflict because v5 removes the peer dependencies on@dfinity/*libs.Change
@icp-sdk/core@dfinity/agentetc. librariesNotes
The imports were already migrated to
@icp-sdk/core.