You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Uses BigInt for numbers that are actually supposed to be big integers according to the API.
Unfortunately, this fix required using a custom JSON parser and serializer, provided by the json-with-bigint package. Reimplementing it was not worth it. I've pinned the version of the package so that it minimizes the risk of introducing any vulnerabilities with future patches of the package.
@peterpeterparker the PocketIC API doesn't support parsing BigInt object format used by @dfinity/utils ({ "__bigint__": string }), it just expects plain numbers
@peterpeterparker when parsing a PocketIC server JSON response that contains a bigint, e.g. EncodedGetTimeResponse, we cannot use the jsonReviver from @dfinity/utils because that assumes the bigint field (in this case nanos_since_epoch) has shape { "__bigint__": string }, which is not the case for the PocketIC server API.
The nanos_since_epoch field is just a number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses BigInt for numbers that are actually supposed to be big integers according to the API.
Unfortunately, this fix required using a custom JSON parser and serializer, provided by the json-with-bigint package. Reimplementing it was not worth it. I've pinned the version of the package so that it minimizes the risk of introducing any vulnerabilities with future patches of the package.
Additionally, fixes #193.