feat(deploy-to-cloud-engine): document app icon metadata (__META_BASE_URL + __META_ICON_PATH)#228
Merged
Merged
Conversation
…console The skill covered name/label/Open metadata but not the app icon. Add the icon pair, with behavior verified against the console source (the control-panel frontend that renders these), not guessed: - `__META_BASE_URL` — app 'Open' link and icon base; must be an absolute https URL (the console rejects non-https / data: / javascript:). - `__META_ICON_PATH` — icon path resolved against the base (new URL(iconPath, baseUrl)); rendered as <img src>. - Both are read ONLY from the main canister; the icon has no fallback, so a missing/invalid base or a path on a side canister means no icon. - The variable is `__META_ICON_PATH`, not `__META_ICON_LINK`/`_ICON`/`_LOGO` (a common wrong guess) — Pitfall 8 calls this out. - Env values are length-capped (~128 chars), so a data: URI does not fit; it is a served path by design. Pitfall 9 + the adversarial eval cover it. - Note the deploy-twice ordering: the frontend canister id is only known after the first deploy, so set the base URL then re-deploy. Evals: 'Give the app an icon' output eval, 'icon not showing (data URI / wrong canister)' adversarial, and a should_trigger icon query. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Skill Validation ReportValidating skill: /home/runner/work/icskills/icskills/skills/deploy-to-cloud-engineStructure
Frontmatter
Markdown
Tokens
Content Analysis
Contamination Analysis
Result: passed Project Checks |
artkorotkikh-dfinity
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the deploy-to-cloud-engine skill documentation and evaluation suite so agents correctly set cloud-engine console metadata for both app naming and app icons, based on __META_BASE_URL + __META_ICON_PATH read from the main canister.
Changes:
- Documented
__META_BASE_URLand__META_ICON_PATHrequirements, placement (main canister only), and validation/pitfalls in the skill guide. - Updated the skill frontmatter description and the Verify step to include icon behavior.
- Added evaluation cases and trigger queries covering icon setup and adversarial misconfigurations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| skills/deploy-to-cloud-engine/SKILL.md | Documents icon metadata variables and clarifies how the engine console derives the app icon. |
| evaluations/deploy-to-cloud-engine.json | Adds eval coverage and trigger queries for icon configuration and common misconfigurations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…pen-link fallback Address Copilot review on Step 2: separate which canister is the metadata source (__META_MAIN_CANISTER) from the Open-button URL value (__META_BASE_URL). Also correct the claim that an invalid/missing base URL drops the "Open" link — per control-panel's grouping logic it falls back to the main canister's gateway URL, so only the icon is lost. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
raymondk
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The deploy-to-cloud-engine skill could name an app in the engine console but not give it an icon. I tried to add one and used the wrong env var (
__META_ICON_LINK), which the console ignores. Checked the control-panel source: the icon comes from__META_BASE_URL+__META_ICON_PATHread off the main canister, so this documents it.Changes
__META_BASE_URLand__META_ICON_PATH, both set on the main canister, for the console app icon.https://URL, and the icon path is a served asset path (not adata:URI).__META_ICON_LINK), and setting the icon on the wrong canister or without a base URL.