Skip to content

feat: add missing signer redirect - #203

Merged
nikosxenakis merged 4 commits into
dfinity:mainfrom
sea-snake:patch-2
Apr 8, 2026
Merged

feat: add missing signer redirect#203
nikosxenakis merged 4 commits into
dfinity:mainfrom
sea-snake:patch-2

Conversation

@sea-snake

Copy link
Copy Markdown
Contributor

Add missing signer redirect entries.

Copilot AI review requested due to automatic review settings April 8, 2026 10:31
@sea-snake
sea-snake requested a review from a team as a code owner April 8, 2026 10:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two missing redirect entries for the /signer service to the redirect configuration. However, there is a critical inconsistency in the implementation.

Changes:

  • Add redirect from /signer to /canisters/latest (HTTP 302)
  • Add redirect from /signer/ to /signer/latest (HTTP 302)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread redirects.ts Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nikosxenakis
nikosxenakis previously approved these changes Apr 8, 2026
@github-actions
github-actions Bot dismissed nikosxenakis’s stale review April 8, 2026 17:02

Review dismissed by automation script.

@nikosxenakis
nikosxenakis enabled auto-merge (squash) April 8, 2026 17:04
nikosxenakis
nikosxenakis previously approved these changes Apr 8, 2026
@github-actions
github-actions Bot dismissed nikosxenakis’s stale review April 8, 2026 17:10

Review dismissed by automation script.

@nikosxenakis
nikosxenakis merged commit f72db74 into dfinity:main Apr 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants