fix: Remove canonicalization from path validation#626
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts bundling path validation to avoid filesystem canonicalization for plugin sync paths, allowing sync directories that are created during the canister build step (and therefore don’t exist yet at validation time).
Changes:
- Replace sync-source validation based on
canonicalizewith a lexical (no-syscall) resolver that still rejects paths escaping the project directory. - Add an integration test ensuring a build-produced synced directory is accepted and included in the resulting bundle archive.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/icp-cli/src/operations/bundle.rs | Reworks sync source validation to lexically resolve paths within the project instead of canonicalizing non-existent build outputs. |
| crates/icp-cli/tests/bundle_tests.rs | Adds a regression test for bundling a plugin dirs: entry that is created by the build step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lwshang
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundling validates paths using canonicalize. However, these paths may not exist yet, because the build step is supposed to generate them. This fixes validation to use parent-dir analysis without canonicalize.