fix: Update time of HTTP outcalls contexts when moving them to delivered - #11214
Open
eichhorl wants to merge 2 commits into
Open
fix: Update time of HTTP outcalls contexts when moving them to delivered#11214eichhorl wants to merge 2 commits into
delivered#11214eichhorl wants to merge 2 commits into
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to 3ea40bf. Security Overview
Detected Code Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP outcalls contexts are moved to a different
deliveredcollection, as soon as the response is delivered. There, they wait for further asynchronous refunds to be delivered. Previously, the context would be removed from this collection after a timeout of 2 minutes, since the creation of the original context.With this PR, we instead update the context's time when moving it to
delivered, and remove it after a timeout of 1 minutes, since the insertion intodeliveredcontexts. This reduces the amount of time that the context needs to stay in replicated state.Additionally, we add metrics for the amount of cycles being refunded. We observe the total amount, and its fraction against the per-replica allowances.