chore: deflake //rs/ledger_suite/icp/ledger:ledger_canister_test#10397
Open
mraszyk wants to merge 1 commit into
Open
chore: deflake //rs/ledger_suite/icp/ledger:ledger_canister_test#10397mraszyk wants to merge 1 commit into
mraszyk wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deflakes the state-machine archiving test used by //rs/ledger_suite/icp/ledger:ledger_canister_test by removing a timing-sensitive assertion about archived_ranges being empty immediately after an archive is created, while keeping the core invariant check that a block is never reported in two places at once.
Changes:
- Removed the assertion that
get_blocks_res.archived_ranges.is_empty()right after the archive appears. - Updated the surrounding test commentary to focus on the “not reported in two places simultaneously” invariant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5123
to
+5125
| // Verify that block `0` is not reported in two places simultaneously: either it is | ||
| // still in local storage (archiving in progress) or it has been moved to the archive | ||
| // (archiving completed), but never both at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deflakes
//rs/ledger_suite/icp/ledger:ledger_canister_test: Removed the assertion thatarchived_ranges.is_empty()after the archive is created. The test still verifies the key property — blocks are never reported in two places simultaneously — but no longer requires catching the ledger in a mid-archiving state. With Rust 1.95.0 (to be bumped in a separate PR), archiving completes within the same ticks used to wait for archive creation.