Skip to content

build: modernize build-system requires - #1309

Merged
ben-edna merged 1 commit into
mainfrom
build/modernize-build-system-requires
Jun 23, 2026
Merged

build: modernize build-system requires#1309
ben-edna merged 1 commit into
mainfrom
build/modernize-build-system-requires

Conversation

@spoorcc

@spoorcc spoorcc commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Drop wheel from [build-system].requires — pip has handled wheel building automatically since pip 21.3, so declaring it is redundant
  • Add setuptools>=80 floor — recommended by setuptools-scm 10.x docs; support for older setuptools is deprecated and will be removed in a future release

Test plan

  • CI builds (wheel, nuitka) pass without wheel in build-system requires
  • No functional change to the built package

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated build system configuration with minimum version constraints to improve build reliability and consistency.

Drop redundant `wheel` (pip handles this since 21.3) and add
`setuptools>=80` floor as recommended by setuptools-scm 10.x docs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59dc0558-7eb0-4a3a-8a1f-43787488b5c6

📥 Commits

Reviewing files that changed from the base of the PR and between 601b6bc and 67c7f25.

📒 Files selected for processing (1)
  • pyproject.toml

Walkthrough

In pyproject.toml, the [build-system] requires list is updated to pin setuptools>=80 (previously unpinned) and removes the wheel entry from the build dependencies. No other project metadata or dependency lists are affected.

Changes

Build System Dependency Update

Layer / File(s) Summary
Update build-system requires
pyproject.toml
[build-system].requires changed from ["setuptools", "wheel"] to ["setuptools>=80"], adding a minimum version constraint and dropping the explicit wheel requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'build: modernize build-system requires' directly and clearly summarizes the main change: updating the build system requirements in pyproject.toml with modernized constraints.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/modernize-build-system-requires

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ben-edna
ben-edna merged commit a99584f into main Jun 23, 2026
36 checks passed
@ben-edna
ben-edna deleted the build/modernize-build-system-requires branch June 23, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants