Normalize imports to Black/isort, add .isort.cfg, and silence E402 in markov_comparison - #13
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
blackandisortso style checks are stable.E402warning for a splittheory.dynamicsimport insimulations/markov_comparison.pywithout changing import semantics.Description
.isort.cfgwithprofile = blackandline_length = 88to alignisortwith Black conventions.experiments/__init__.py,experiments/leggett_garg/__init__.py,experiments/process_tensor/__init__.py,experiments/reset_tests/__init__.py,simulations/__init__.py, andtheory/__init__.pyto use Black-friendly multi-line grouping while preserving__all__and exported symbols.simulations/markov_comparison.pyto split thetheory.dynamicsimports and attach# noqa: E402to each line to suppress the module-level import ordering warning without changing behavior.Testing
flake8 theory/ analysis/ simulations/ experiments/ tests/ --count --show-source --statisticsand it returned no errors (0).black --check theory/ analysis/ simulations/ experiments/ tests/and the files passed Black checks.isort --check-only --diff theory/ analysis/ simulations/ experiments/ tests/andisortreported no ordering violations.Codex Task