Align imports with Black/isort and add isort config - #12
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
blackandisortstyle checks so CI/style checks pass.# noqamarkers while normalizing import layout across modules.Description
.isort.cfgwithprofile = blackto makeisortfollow Black's import formatting conventions.experiments/__init__.py,experiments/leggett_garg/__init__.py,experiments/process_tensor/__init__.py,experiments/reset_tests/__init__.py,simulations/__init__.py,simulations/markov_comparison.py, andtheory/__init__.pyto match Black/isort expectations without changing exported symbols.simulations/markov_comparison.pyto split thetheory.dynamicsimport so the# noqa: E402comment remains correctly associated while satisfyingisort/blackformatting rules.Testing
isort --check-only --diff theory/ analysis/ simulations/ experiments/ tests/and iteratively fixed import ordering untilisort --check-only --diff ...returned no errors.black --check theory/ analysis/ simulations/ experiments/ tests/which reported no remaining formatting violations.blackinitially reformatted the seven affected files and subsequentblack --checkshowed the files were stable.Codex Task