Karpenter EC2NodeClass supports maxPods and kubeReserved directly in the spec#607
Open
wcarlsen wants to merge 2 commits into
Open
Karpenter EC2NodeClass supports maxPods and kubeReserved directly in the spec#607wcarlsen wants to merge 2 commits into
wcarlsen wants to merge 2 commits into
Conversation
…the spec Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid setting maxPods and kubeReserved in user_data, since it can lead to Karpenter not taking the extra reserved resources into account, when pulling in new nodes, leading to infinite loops of pulling in the same instance types with insufficient available resources.
Align learnings from this PR to Karpenter nodes dfds/infrastructure-modules#2382