Skip to content

Always provision source controller IRSA role with the cluster and allow for pulls through pull through cache#2396

Open
wcarlsen wants to merge 3 commits into
masterfrom
bug/fluxcd-bootstrap-git/flaky-diffs-and-source-ctrl-not-able-to-pull-from-cache
Open

Always provision source controller IRSA role with the cluster and allow for pulls through pull through cache#2396
wcarlsen wants to merge 3 commits into
masterfrom
bug/fluxcd-bootstrap-git/flaky-diffs-and-source-ctrl-not-able-to-pull-from-cache

Conversation

@wcarlsen

@wcarlsen wcarlsen commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Currently source controller IRSA role is a shared role from shared-prod account, but since we implement allowed pulls if it is form an org account, we no longer need the shared account approach. So we let the clusters bring its own. We also solve a bug with the shared-prod IRSA role missing permissions to pull images from the pull through cache. Lastly this hopefully removes flaky diffs and random failures on fluxcd_bootstrap_git resource as described here https://dfds.slack.com/archives/CQD754GGL/p1782994535687589.

Issue ticket number and link

Checklist before requesting a review

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

…ow for pulls through pull through cache

Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
@wcarlsen wcarlsen requested a review from a team as a code owner July 2, 2026 14:14
@wcarlsen wcarlsen added the release:major Triggers a major release label Jul 2, 2026
@DFDS-Snyk

DFDS-Snyk commented Jul 2, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@wcarlsen

wcarlsen commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I guess that triggered a bug in the provider 🙈

@wcarlsen

wcarlsen commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

I guess that triggered a bug in the provider 🙈

So on first run this fails, with an inconsistent plan from the provider, but it disappears on second run.

wcarlsen added 2 commits July 3, 2026 10:51
…ent plans on first run and fails when replacements come from other resources.

Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:major Triggers a major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants