ci: split apiCheck into its own CI step for cost visibility#72
Merged
Conversation
apiCheck now transitively compiles the Android target via androidApiCheck -> androidApiBuild -> compileAndroidMain, but its cost was folded into one bundled ktlint/detekt/apiCheck/jvmTest/koverVerify step, making it invisible in the job's timing. Splitting it into its own step surfaces that cost on its own line without changing what runs or how it's cached.
The apiCheck step now carries its own task graph, separate from the ktlint/detekt/jvmTest/koverVerify step, so it can hit or miss the configuration cache independently. Surface that signal the same way the other step already does instead of leaving it only in the raw log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static-analysisjob's bundledktlint, detekt, binary-compatibility and JVM coverage floorstep into two:ktlint, detekt, and JVM coverage floor(runsktlintCheck detekt jvmTest koverVerify) and a newapiCheck (binary compatibility, incl. Android + native KLIB ABI)step (runsapiCheckalone).Why
apiChecknow transitively compiles the Android target (androidApiCheck -> androidApiBuild -> compileAndroidMain) as part of its binary-compatibility checking, a real new cost that was previously invisible because it was folded into one opaque ~176s bundled step. Splitting it into its own step surfaces that cost as its own line in the job's timing, so it's attributable instead of hidden inside the combined ktlint/detekt/jvmTest/koverVerify block.