docs(operations): record the 2026-09-16 observability computation-contract review - #854
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Maintenance plan §12.1 asks for a computation-contract review of the existing aggregate observation code before any new collection work. This PR records that review as one dated ops document. Read-only: no code, schema, retention, SDK, or receipt change.
What was reviewed
api/pro-monitor.js,src/web-observability.js,api/funnel.js,playground/analytics.jsatorigin/dev75bcf7f, by static read (no production probe, no credentials).Verdict
All seven §12.1 rules: OK (0 violations, 2 cautions, 2 follow-up bullets — see the findings table with file:line anchors). Notable mechanisms: same-collection-only ratios, explicit denominators + logWindows in every receipt, bucket-bound p95 with no exact-percentile claim, fail-closed
monitor_blind/503, closed outcome sets separating cancel/auth/quota/provider/product/below-floor, and ruleVersion/schema-hash pinning for series changes.Scope / verification
docs/operations/observability-contract-review-20260916.md. No existing file touched.npm run check:no-private-assets: 0 forbidden paths across 503 packed + 1388 tracked (exit 0).Why (Issue omission)
Documentation-only review record with no behavior or contract change — low-risk exemption per docs/WORKFLOW.md P02a; the work item is maintenance plan §12.1.