Skip to content

ci: bound release and dataset jobs with explicit timeouts - #853

Merged
devswha merged 1 commit into
devfrom
bot/ci-hygiene-8-1
Sep 15, 2026
Merged

devswha merged 1 commit into
devfrom
bot/ci-hygiene-8-1

Conversation

@devswha

@devswha devswha commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Purpose

Maintenance plan §8.1 (CI waste removal without reducing verification) — residual gap closure. Investigation found §8.1 substantially already shipped in test.yml: per-PR concurrency with cancel-in-progress scoped to pull_request events only (group keys workflow + event + ref + PR number), workflow-level permissions: contents: read, timeout-minutes: 15 on all three jobs, and the Node-matrix duplication finding recorded in-file (lts/* currently resolves to 24.20.0; a fixed 24 entry would duplicate it — matrix intentionally unchanged, floating test (lts/*) is a required check). release.yml already has its dedicated patina-release-publication group with cancel-in-progress: false (release publication can never be cancelled by PR runs) and minimal per-job permissions.

The only §8.1 element missing was explicit job timeouts on release.yml and publish-dataset.yml. This PR adds exactly those.

Changes (6 lines, workflows only)

Workflow Job timeout-minutes Basis
release.yml verify 20 full gate suite, observed ≈3 min
release.yml authorize-source 10 metadata-only
release.yml npm 30 publish + post-publish registry polling (#843)
release.yml github-release 15 release creation
release.yml ghcr 30 image build/push
publish-dataset.yml dataset 30 manual HF export

Observed release-run durations: 2026-09-10 success ≈3 min; 2026-09-15 failure ≈42 min (auth failure + waiting) — bounds are ≥3x observed successes.

Not changed

No check name, job, matrix entry, trigger, permission, or concurrency group is added, removed, or renamed. No Node-floor or matrix change (out of scope per plan; existing in-file finding stands). The #850 Redis quality steps are untouched.

Verification

  • YAML parse of all three workflows via js-yaml: OK (exit 0).
  • Hosted CI on this PR is the behavioral check for test.yml (unchanged) — timeouts on release jobs are exercised on the next release run; failure mode is a bounded kill instead of an unbounded hang, rollback = revert this PR.

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
patina Ready Ready Preview Sep 15, 2026 4:53pm UTC

Request Review

@devswha
devswha merged commit 7519654 into dev Sep 15, 2026
8 checks passed
@devswha devswha mentioned this pull request Sep 15, 2026
@devswha
devswha deleted the bot/ci-hygiene-8-1 branch September 16, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant