fix: prevent bypass confirmation dialog jump - #25
Merged
Conversation
devswha
approved these changes
Sep 4, 2026
devswha
left a comment
Owner
There was a problem hiding this comment.
Verified the mechanism: @keyframes dialog-content-show animates transform from translate(-50%, -48%) scale(0.96), which replaces the centering translate for the 150 ms entrance — a real snap, and a moving frame is especially wrong on a destructive-action confirmation. animate-none through cn() correctly overrides animate-dialog-content-show (tailwind-merge conflict group / emit order both land on animate-none), scoped to this dialog only. Dom test 5/5 green on current main. LGTM.
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Why
Selecting Bypass could render the confirmation dialog briefly off its final centered position before it snapped into place. The common dialog animation overrides the transform used for centering. This change keeps the safety confirmation at its final center position from its first rendered frame.
Reproduction
Expected: the dialog appears at its final centered position.
Actual before this change: the dialog could begin offset and visibly snap into the center during its entrance animation.
Scope and impact
Related work
No related issues or pull requests found after searching the upstream repository for
bypass dialog.Verification
dist-native/bun test src/components/chat/view/PermissionModePicker.dom.bun.test.tsx— 5 passed.npm run lint— passed.npm run build— passed.npm run verifyreached and passed audit, license, notices, typecheck, and Rust-core checks, but the repository-wide Node test run currently fails in nine unrelated client suites becausereact-syntax-highlighter@16.1.1does not exportoneDarkfromreact-syntax-highlighter/dist/esm/styles/prism. This branch does not touch the syntax-highlighter import or its dependency version.npm run verifypasses, or I have said below which gate fails and why.