Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ export const buildOpenCodeDefinitionFromVerboseModels = (
};
};

const parseOpenCodeSessionModelValue = (rawModel: unknown): string | null => {
export const parseOpenCodeSessionModelValue = (rawModel: unknown): string | null => {
if (typeof rawModel === 'string') {
const trimmed = rawModel.trim();
if (!trimmed) {
Expand All @@ -376,8 +376,13 @@ const parseOpenCodeSessionModelValue = (rawModel: unknown): string | null => {
return null;
}

return readOptionalString(record.id)
?? readOptionalString(record.model)
const id = readOptionalString(record.id);
const providerId = readOptionalString(record.providerID);
if (id) {
return id.includes('/') || !providerId ? id : `${providerId}/${id}`;
}

return readOptionalString(record.model)
?? readOptionalString(record.name)
?? readOptionalString(record.value)
?? null;
Expand Down
5 changes: 5 additions & 0 deletions server/modules/providers/services/provider-models.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ export const createProviderModelsService = (dependencies: ProviderModelsServiceD
return changedModel.model.trim();
}

const currentModel = await getCurrentActiveModel(provider, sessionId);
if (currentModel.model?.trim()) {
return currentModel.model.trim();
}

return normalizedRequestedModel || undefined;
};

Expand Down
18 changes: 18 additions & 0 deletions server/modules/providers/tests/opencode-models.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,27 @@ import {
buildOpenCodeDefinitionFromVerboseModels,
buildOpenCodeDefinitionFromIds,
parseOpenCodeModelsStdout,
parseOpenCodeSessionModelValue,
parseOpenCodeVerboseModelsStdout,
} from '@/modules/providers/list/opencode/opencode-models.provider.js';

test('OpenCode session model parser preserves the provider-qualified model id', () => {
assert.equal(
parseOpenCodeSessionModelValue(JSON.stringify({
id: 'gpt-5.5',
providerID: 'openai',
})),
'openai/gpt-5.5',
);
assert.equal(
parseOpenCodeSessionModelValue({
id: 'anthropic/claude-sonnet-4-5',
providerID: 'anthropic',
}),
'anthropic/claude-sonnet-4-5',
);
});

test('OpenCode models provider parses plain CLI output and removes duplicates', () => {
const ids = parseOpenCodeModelsStdout(`
opencode/big-pickle
Expand Down
20 changes: 20 additions & 0 deletions server/modules/providers/tests/provider-models.service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,3 +347,23 @@ test('resolveResumeModel prefers a stored changed model over the requested one',
await rm(tempRoot, { recursive: true, force: true });
}
});

test('resolveResumeModel prefers the provider session model over the requested default', async () => {
const service = createProviderModelsService({
resolveProvider: (provider) => ({
models: {
getSupportedModels: async () => createModels(`${provider}-models`),
getCurrentActiveModel: async () => createCurrentActiveModel('openai/gpt-5.5'),
changeActiveModel: async (input) => createSessionActiveModelChange(provider, input),
},
}),
});

const model = await service.resolveResumeModel(
'opencode',
'session-native-opencode',
'anthropic/claude-sonnet-4-5',
);

assert.equal(model, 'openai/gpt-5.5');
});
Loading