Skip to content

Fix Windows PowerShell service crash boundary - #17

Open
devnoname120 wants to merge 2 commits into
mainfrom
fix/issue-15-windows-exec-crash
Open

devnoname120 wants to merge 2 commits into
mainfrom
fix/issue-15-windows-exec-crash

Conversation

@devnoname120

Copy link
Copy Markdown
Owner

Summary

  • prefer PowerShell 7 for Windows model-selected/default command execution and never downgrade an explicit pwsh request to Windows PowerShell 5.1
  • replace the persistent PowerShell Scheduled Task launcher with a native codexify service launch restart loop, preserving hidden task execution, bounded backoff, output capture, and Job Object process-tree cleanup
  • migrate exact encoded and file-based legacy launchers while preserving modified/custom task actions
  • document the revised Windows shell and service contracts

Root-cause boundary

The issue evidence does not prove a single internal Rust fault: v2.3.24 already used CREATE_NO_WINDOW, the audit ends after worker spawn without a Rust panic/return marker, and the exact workload passes through PowerShell 7, cmd, Python, and C# routes while reproducing through Windows PowerShell 5.1. The defensible boundary is therefore the implicit legacy PowerShell host plus the persistent PowerShell task root. This change removes both from the default service path rather than attributing the failure to the 1 MiB buffer.

Verification

  • red/green regressions for strict pwsh matching and native task registration
  • focused launcher, migration, CLI, console-detach, task-definition, and process-tree tests
  • cargo fmt --all --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo test --all-targets --all-features -- --test-threads=1

The existing service-platforms CI matrix will compile and run the service/self-update contracts on windows-latest.

Fixes #15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codexify 2.3.24: exact 1 MiB PowerShell reproducer still stops the native Windows service on affected Windows 10 machine

1 participant