Repository navigation
fix(media): never use a scanned document as a portrait - #38
Merged
Merged
Conversation
A person whose first image was a certificate scan (FORM.MEDI OTHER) got it as the round portrait on the chart and in the card. A portrait is now an image that is a photo (MEDI PHOTO) or of unknown medium; documents, cards and tombstones stay in the media list only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People whose first image was a scanned certificate (`FORM.MEDI OTHER`) showed the scan as their round portrait on the chart and in the card.
A portrait is now an image that is a photo (`MEDI PHOTO`) or of unknown medium (most files carry no MEDI). Images with another medium (documents, cards, tombstones) stay in the card's media list and the viewer only. Same rule on the chart (`photoOf`) and in the card (`portraitOf`), via `isPortraitFile`.
🤖 Generated with Claude Code