Skip to content

fix: address instantiation timing issues with SOL - #2013

Merged
rsdmike merged 2 commits into
mainfrom
fixSOL
Aug 20, 2025
Merged

fix: address instantiation timing issues with SOL#2013
rsdmike merged 2 commits into
mainfrom
fixSOL

Conversation

@rsdmike

@rsdmike rsdmike commented Aug 20, 2025

Copy link
Copy Markdown
Member

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

Copilot AI review requested due to automatic review settings August 20, 2025 22:26

This comment was marked as outdated.

graikhel-intel
graikhel-intel previously approved these changes Aug 20, 2025
@rsdmike
rsdmike requested a review from Copilot August 20, 2025 22:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses instantiation timing issues in the SOL (Serial Over LAN) component by removing the artificial 4-second delay and simplifying the connection lifecycle management.

  • Removes AfterViewInit lifecycle hook and setTimeout delay for more immediate SOL connections
  • Consolidates initialization logic into the device connection effect
  • Updates tests to reflect the new synchronous behavior

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
sol/src/sol.component.ts Removes timing delays and simplifies SOL connection lifecycle
sol/src/sol.component.spec.ts Updates tests to work with synchronous initialization and adds new test coverage
package.json Updates ui-toolkit dependency version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread sol/src/sol.component.ts
@rsdmike
rsdmike merged commit 727f06e into main Aug 20, 2025
5 checks passed
@rsdmike
rsdmike deleted the fixSOL branch August 20, 2025 22:58
@RosieAMT

Copy link
Copy Markdown

🎉 This PR is included in version 10.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants