feat: add support for hotkeys - #1984
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds hotkey support to the KVM component, allowing users to send predefined keyboard shortcuts to remote devices. The implementation includes various Windows and standard keyboard combinations like Ctrl-Alt-Del, Alt-Tab, and Windows key sequences.
- Adds hotkey input property and effect handler to trigger hotkey sequences
- Implements sendHotkey method with timing-based key sequence execution
- Provides comprehensive hotkey mapping for common Windows and system shortcuts
Comments suppressed due to low confidence (1)
kvm/src/kvm.component.ts:229
- The sendHotkey method and its complex key sequence logic lack test coverage. Consider adding unit tests to verify correct key sequences are generated and sent for each hotkey type.
sendHotkey(hotKeyType: string): void {
rsdmike
force-pushed
the
kvmEnhancement
branch
2 times, most recently
from
July 29, 2025 20:00
7032f61 to
1827413
Compare
madhavilosetty-intel
approved these changes
Jul 29, 2025
RosieAMT
pushed a commit
that referenced
this pull request
Jul 29, 2025
# [10.1.0](v10.0.0...v10.1.0) (2025-07-29) ### Features * add support for hotkeys ([#1984](#1984)) ([47ce911](47ce911))
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contributes to #1391
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )