ci: bump security report action to v4.1.0 and surface its failures - #2644
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CodeQL workflow’s “Generate Security Report” step to use a newer pinned version of rsdmike/github-security-report-action, and changes CI behavior so report-generation failures are no longer silently ignored while still avoiding failures on fork PRs where the required secret is unavailable.
Changes:
- Bump
rsdmike/github-security-report-actionfrom v4.0.1 to v4.1.0 (pinned SHA). - Remove
continue-on-error: truefrom the security report generation step so real failures fail the job. - Add an
if:guard so the step is skipped on fork PRs wheresecrets.SECURITY_TOKENis not available.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rsdmike
force-pushed
the
ci/security-report-v4.1.0
branch
from
September 1, 2026 19:51
d41ac87 to
7cf2610
Compare
v4.1.0 drops the `dependencies` expansion from the dependency-graph GraphQL query, which was returning `timedout` and stalling the CodeQL job, and reads the package list from the SBOM REST API instead. Drop `continue-on-error` from the report step so genuine failures are visible rather than being rewritten to a success conclusion. Guard the step for the two cases where SECURITY_TOKEN is unreachable and the action fails on an empty input: pull requests from forks, and Dependabot runs, which read a separate secret store. Gate the rename and upload steps on the report step's own outcome, since a skipped step does not stop the steps after it and `mv` would error on a file that was never created. Claude-Session: https://claude.ai/code/session_01VivkdrFB8x5pEWnxmM6gMm
rsdmike
force-pushed
the
ci/security-report-v4.1.0
branch
from
September 1, 2026 20:12
7cf2610 to
84d7e74
Compare
rsdmike
enabled auto-merge (rebase)
September 1, 2026 20:31
madhavilosetty-intel
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Generate Security Report step in this workflow has been failing and producing no PDF:
This was invisible because the step carries
continue-on-error: true— the CodeQL job stayed green and GitHub's API reported the step'sconclusionassuccess, sincecontinue-on-errorrewrites it. The failure existed only in the raw logs.Root cause was in the action: it expanded
dependencyGraphManifests.dependenciesover GraphQL, which makes GitHub resolve every manifest's full dependency graph. A large lockfile exceeds the server-side budget and times out. Fixed in rsdmike/github-security-report-action#274, released as v4.1.0.Changes
rsdmike/github-security-report-actionfrom v4.0.1 to v4.1.0 (a3d8cc0, verified to match thev4.1.0tag).continue-on-error: truefrom that step so failures fail the job.SECURITY_TOKENis not exposed to fork PRs, and the action reads it viacore.getInput('token', { required: true }), which throwsInput required and not supplied: tokenon an empty value. Without the guard, removing the suppression would fail the whole CodeQL job on external contributions.Verification
This exact change was verified end to end in ui-toolkit-angular#2578: the report step went from failing in 5.4s with no output, to succeeding in 12s and uploading a 132KB PDF artifact — with the guard confirmed not to skip the step on same-repo PRs.
The CodeQL run on this PR exercises it here.
Notes
continue-on-erroris deliberately left on Rename Report and Upload Artifacts; those are unreachable if the report step fails now.timedouterror — the fix and the suppression removal are correct regardless, and this PR's own CodeQL run will demonstrate it.https://claude.ai/code/session_017rtnF1RVUGPNwD6f7EL8cB