ci(gh-actions): resolve zizmor findings - #2592
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Zizmor security findings in the repository’s GitHub Actions workflows by hardening checkout credential handling and reducing risk of expression/template injection in a shell run step. It also introduces a Zizmor config file to document an intentional exception for Dependabot cooldown findings.
Changes:
- Disable persisted Git credentials (
persist-credentials: false) foractions/checkoutacross multiple workflows that don’t need to push to the repo. - Refactor
docker-image.ymlto pass workflow inputs via step-levelenvand reference them as quoted shell variables in theruncommand. - Add
.github/zizmor.ymlto configure/ignoredependabot-cooldownwith rationale.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/zizmor.yml | Adds Zizmor configuration to ignore a specific rule (Dependabot cooldown) with a documented rationale. |
| .github/workflows/api-test.yml | Disables persisted checkout credentials for the API test workflow. |
| .github/workflows/codeql-analysis.yml | Disables persisted checkout credentials for CodeQL workflow checkout. |
| .github/workflows/docker-image.yml | Disables persisted checkout credentials; moves inputs into env and quotes shell variable usage to mitigate injection risk. |
| .github/workflows/node.js.yml | Disables persisted checkout credentials for Node.js CI workflow. |
| .github/workflows/semantic.yml | Disables persisted checkout credentials while keeping full history checkout for PR semantic validation. |
| .github/workflows/trivy-scan.yml | Disables persisted checkout credentials for Trivy scan workflow. |
- Set persist-credentials: false on actions/checkout in api-test, codeql-analysis, docker-image, node.js, semantic and trivy-scan workflows; none of these jobs push back to git. - Move the docker_registry / docker_tag_name inputs out of the docker-image build run block into step-level env vars, referenced as quoted shell variables, to avoid template injection. - Add .github/zizmor.yml ignoring dependabot-cooldown, with a note on why daily uncooled updates are acceptable here.
madhavilosetty-intel
force-pushed
the
ci/fix-zizmor-findings
branch
from
July 21, 2026 18:17
e97b07e to
e860235
Compare
sudhir-intc
approved these changes
Jul 22, 2026
|
🎉 This PR is included in version 2.34.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )