Reject unsupported output fields before dispatch - #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
What changed
fieldsvalues before Bridge dispatchfor
list_tasks,get_task,list_projects, andlist_folders.list_tags.fieldsrejected until Add parent-aware tag search and hierarchy to list_tags #70 introduces that separate querysurface.
Why
Unknown field names previously reached output shaping, where they were silently
ignored. A client could therefore receive a plausible successful response and
reason as though the requested value had been inspected. The new contract fails
closed with the tool name, unsupported values, and supported alternatives.
No OmniFocus task names, project names, notes, IDs, or other personal content
are included.
User impact
Mistyped or invented fields now fail immediately and clearly instead of
returning incomplete-looking success. Models can discover the valid
case-sensitive values directly from the tool schema.
Catalog measurement
The tool count is unchanged.
Validation
swift run focusrelay-dev validate --impact server-wiretool.
list_tags.fieldsfail-closed coverage passed.validation error.
git diff --checkpassed.One direct
swift testinvocation initially hit SwiftPM's nestedsandbox-execmanifest restriction; the same targeted regression passed outside the managed
workspace sandbox.