Repository navigation
fix(packaging): ship upstream's THIRD-PARTY-NOTICES.txt instead of legal/ - #11
Closed
ryan-morris wants to merge 1 commit into
Closed
ryan-morris wants to merge 1 commit into
ryan-morris wants to merge 1 commit into
Conversation
…gal/
Upstream's archives moved to the ffmpeg-build engine, which drops the
legal/ directory and puts one THIRD-PARTY-NOTICES.txt at every archive's
root, the iOS xcframework bundle included. Packing still looked for
legal/, so every platform package would have shipped with no licence
text and failed verify-packages.py, and the Apple packages had no
notices to copy at all.
- pack.sh moves the archive's notices file to the package root (never
under runtimes/{rid}/native/, where NuGet would copy it into every
consumer's output) and copies the iOS bundle's into each Apple
package; an archive without one fails the pack
- Runtime.csproj and Apple.csproj pack THIRD-PARTY-NOTICES.txt at the
package root
- verify-packages.py requires it at the root of every platform package
and rejects a copy anywhere else
- audit-upstream.py reports has_notices instead of has_legal
- README and the design spec describe the new file
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Folded into #12, so there's one PR to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devenvy/ffmpeg now builds with ffmpeg-build (devenvy/ffmpeg#60, merged). Its archives carry one
THIRD-PARTY-NOTICES.txtat the root (the variant's license notice and every bundled library's license text) instead of thelegal/folder. This packs that file into the NuGet packages in place oflegal/.Merge before the next FFmpeg bump. The first ffmpeg-build releases (8.1.3.4, 9.0.2.4) are building now; once they're out,
check-updates.ymlwill offer them, and packaging them needs this change.🤖 Generated with Claude Code