Skip to content

fix: a source moved upstream says how to pin it; the canary takes AMF 1.5.3's re-cut - #15

Merged
ryan-morris merged 1 commit into
mainfrom
fix/moved-tag-advice
Oct 19, 2026
Merged

ryan-morris merged 1 commit into
mainfrom
fix/moved-tag-advice

Conversation

@ryan-morris

Copy link
Copy Markdown
Member

Monday's Canary failed its Windows builds: AMD moved AMF's v1.5.3 tag from 8c64800 to a re-cut 57ee0cf (2026-10-16, release re-created; the public headers only gained definitions). The engine refused it, as it should.

  • The advice in that error was wrong. It (and the replaced-archive error) said to run ffmpeg-build update, but update keeps the pin of a version the lock already has, so only deleting the entry and running ffmpeg-build lock takes the new commit or content. Both messages now say just that; tests pin the wording.
  • examples/canary: AMF re-pinned to the new commit (devenvy/ffmpeg gets the same in fix: AMF 1.5.3 pinned to AMD's re-cut of the tag ffmpeg#66).

🤖 Generated with Claude Code

… 1.5.3's re-cut

- A tag that moved, or an archive replaced, upstream told the user to run ffmpeg-build update, but update keeps the
  pin of a version the lock already has: only deleting the entry and running ffmpeg-build lock takes the new commit
  or content. Both messages now say just that.
- examples/canary: AMD moved AMF's v1.5.3 tag to a re-cut commit (2026-10-16; the public headers only gained
  definitions), which failed the canary's Windows builds; its lock pins the new commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 88.87% (🎯 85%) 4787 / 5386
🟢 Statements 88.97% (🎯 85%) 5108 / 5741
🟢 Functions 91.09% (🎯 85%) 1187 / 1303
🟢 Branches 81.71% (🎯 80%) 3196 / 3911
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/build/fetch.ts 75% 64.7% 73.91% 75.18% 48-49, 143-145, 183, 200-203, 214, 221-226, 241-242, 269, 289-295, 311-314, 334-351, 357-373
Generated in workflow #19 for commit adc4943 by the Vitest Coverage Report Action

@ryan-morris
ryan-morris merged commit 3009ca3 into main Oct 19, 2026
40 checks passed
@ryan-morris
ryan-morris deleted the fix/moved-tag-advice branch October 19, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant