Some additional configuration and typing additions/fixes#14
Open
abarciauskas-bgse wants to merge 2 commits into
Open
Some additional configuration and typing additions/fixes#14abarciauskas-bgse wants to merge 2 commits into
abarciauskas-bgse wants to merge 2 commits into
Conversation
…sistency - Add SQS_RETENTION_PERIOD_DAYS setting (with 1-14 day validator) and wire it into the main queue and DLQ - Fix ICECHUNK_PREFIX being passed as a None Lambda env var (CDK requires str) - Align example Processor and Protocol with the handlers: add optional bucket/prefix constructor and pass repo into garbage_collect Co-authored-by: Cursor <cursoragent@cursor.com>
abarciauskas-bgse
changed the title
abarciauskas-bgse
changed the title
Member
|
@abarciauskas-bgse I'll try to integrate these tomorrow. I just started testing the partitioned processing branch with GPM IMERG and realized I needed some of these updates as well 👍 |
maxrjones
reviewed
Jul 23, 2026
maxrjones
left a comment
maxrjones
left a comment
Member
There was a problem hiding this comment.
These changes look good to me! I was just wondering if we should also set a tag in the configuration to make it easier to find CDK stacks templated by virtualizarr-data-pipelines (e.g., aws cloudformation describe-stacks --query "Stacks[?Tags[?Key=='Template' && Value=='virtualizarr-data-pipelines']]")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some additional AWS configuration parameters.
A few other object modeling changes:
repoparameter into processor.garbage_collect (repo seems like a necessary argument to garbage collect, unless we addrepoas an attribute ofProcessor)__init__function in the example processor module. This is not a necessity, given the example is still valid without it, but seems like an almost universal pattern to instantiate the processor with a bucket and prefix that it will store the icechunk repo in. I debated whether to keep this in but thought it useful enough to keep/