Skip to content

fix(ci): don't fail benchmark on fork PRs when an alert fires #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wakame1367 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(ci): don't fail benchmark on fork PRs when an alert fires #1464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ jobs:
tool: 'customSmallerIsBetter'
output-file-path: benchmark.json
alert-threshold: '130%'
comment-on-alert: true
# Only comment on alert when we can actually write to the repository.
# Pull requests from a fork get a read-only GITHUB_TOKEN, so posting the
# alert comment fails with "Resource not accessible by integration" and
# takes the whole job down, despite `fail-on-alert: false`.
comment-on-alert: ${{ github.event.pull_request.head.repo.fork != true }}
fail-on-alert: false
# GitHub API token to make a commit comment
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down