chore(oidc-provider): drop unused AwsExchange builder methods#75
Open
alukach wants to merge 1 commit into
Open
chore(oidc-provider): drop unused AwsExchange builder methods#75alukach wants to merge 1 commit into
alukach wants to merge 1 commit into
Conversation
`with_endpoint`, `with_session_name`, `with_duration`, and `with_session_policy` have no callers anywhere in the workspace. All `AwsExchange` fields are `pub`, so callers that need non-default values set them directly via struct update on `AwsExchange::new(..)`. Remove the dead builders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🚀 Latest commit deployed to https://multistore-proxy-pr-75.development-seed.workers.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
AwsExchangeincrates/oidc-provider/src/exchange/aws.rsexposes four builder methods —with_endpoint,with_session_name,with_duration,with_session_policy— that have zero callers anywhere in the workspace. EveryAwsExchangefield is alreadypub, so a caller needing non-default values sets them directly via struct-update syntax onAwsExchange::new(..). The builders are dead flexibility. Surfaced by a repo-wide over-engineering audit.How I did it
crates/oidc-provider/src/exchange/aws.rs— removed the fourwith_*methods fromimpl AwsExchange, leavingnew()as the sole constructor.Test plan
cargo check -p multistore-oidc-providercargo clippy -p multistore-oidc-provider(clean)cargo fmt🤖 Generated with Claude Code