chore(core): remove unused HandlerAction::response_headers_mut()#74
Open
alukach wants to merge 1 commit into
Open
chore(core): remove unused HandlerAction::response_headers_mut()#74alukach wants to merge 1 commit into
alukach wants to merge 1 commit into
Conversation
The only callers of `response_headers_mut` were its own three unit tests — no production code path used it. Drop the method, its sole `impl HandlerAction` block, and the tests. Can be re-added as integrator API if a real consumer appears. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🚀 Latest commit deployed to https://multistore-proxy-pr-74.development-seed.workers.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
HandlerAction::response_headers_mut()incrates/core/src/route_handler.rshad no callers other than its own three unit tests — no production path mutates response headers through it. It's dead public API kept alive only by the tests that test it. Surfaced by a repo-wide over-engineering audit.How I did it
crates/core/src/route_handler.rs— removed the method and its soleimpl HandlerActionblock, plus the threetest_response_headers_mut_*tests. If an integrator later needs mutable access to response headers, the accessor is trivial to re-add.Test plan
cargo check -p multistorecargo clippy -p multistore(clean)cargo test -p multistore --lib route_handler— 6 passed, 0 failedcargo fmt🤖 Generated with Claude Code