chore(core): remove unused ProxyResponseBody::empty()#73
Open
alukach wants to merge 1 commit into
Open
Conversation
The `empty()` constructor had no callers anywhere in the workspace (including tests) — call sites use the `ProxyResponseBody::Empty` variant directly, and `from_bytes` already collapses empty input to `Empty`. Drop the dead method. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🚀 Latest commit deployed to https://multistore-proxy-pr-73.development-seed.workers.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
ProxyResponseBody::empty()incrates/core/src/route_handler.rshas zero callers anywhere in the workspace — not in production code, not in tests. Call sites constructProxyResponseBody::Emptydirectly, andfrom_bytesalready collapses empty input toEmpty, so the named constructor is dead public API. Surfaced by a repo-wide over-engineering audit.How I did it
crates/core/src/route_handler.rs— deleted theempty()method (and its doc comment) from theimpl ProxyResponseBodyblock.from_bytesis left untouched.Test plan
cargo check -p multistorecargo clippy -p multistore(clean)cargo fmt🤖 Generated with Claude Code