Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the dependencies whose version requirements kept out the latest release, updates the
lockfile for crates with security advisories, and drops unused WebAssembly dependencies. Also adds
tests and benchmarks. Library code changes only where an upgrade requires it.
Dependencies
rstest 0.26 → 0.28 (tests only).
RUSTSEC-2026-0177. pyo3 0.30 is out, but pythonize's latest release still requires 0.29.
advisories. The last three are only built for the DuckDB test dependency.
jsonschema 0.60 turns on getrandom's
wasm_jsfeature itself.Code changes the upgrades force:
src/geometry.rs: geojson 1.0 renamedValuetoGeometryValue, gave its variants namedfields, and made a position a
Positioninstead of aVec.src/validator.rs: jsonschema 0.60 replacedapplyandOutputwithevaluateandEvaluation.Validator::applykeeps its name and now returnsEvaluation. This is the onebreaking change to cql2's own API: use
.is_valid()where you used.flag(), and.list()or.hierarchical()where you used.basic().src/sql.rs: sqlparser 0.63 removedCast'sarrayfield and made aLIKEescape anexpression.
The cql2-text, cql2-json and SQL output is the same as on
main. I compared them with the CLI,for WKT and GeoJSON geometries, LIKE escapes, casts and temporal literals, along with the
validation messages.
Tests and benchmarks
tests/api.rs: the public API's conversions and helpers.tests/ats/expressions.txt: the value-to-value comparisons and interval relations from the OGCCQL2 Abstract Test Suite, and a test that each value compares equal to itself.
tests/encoding_invariants.rs:in(...)called as a function.tests/reduce_tests.rs:dimension.
cql2.pyi.PROPTEST_CASEScan raise the property tests above their usual 2000 cases.benches/cql2.rs: criterion benchmarks of parsing,reduce,filter,to_textandto_sql. Run them withcargo bench --bench cql2.CONTRIBUTING.mdsays how to run each test suite and the benchmarks.Testing
scripts/lint, and clippy with warnings denied over all targetscargo test --workspace --all-featureswasm-pack test --nodeand the JS integration testsmkdocs build --strictcargo bench --bench cql2 -- --testPROPTEST_CASES=30000 cargo test --release --test proptest_roundtripcargo audit: no vulnerabilitiesThis PR was created with the help of Claude.