Repository navigation
wurk rows 8,12: read detect.dup outcome (or graded steps) alongside conclusion - #598
Conversation
A push whose tree already passed on the PR head reports `success` with nothing having run, so rows 8 and 12 of the health brief used to certify main green on a verdict they could not actually establish. Both rows now call `gh api .../actions/runs/<id>/jobs` and branch on the result: an empty or unparseable list surfaces as `verdict unknown <sha>`, a successful `detect changed paths` + every gated job skipped surfaces as `Unhealthy: <sha> is a dup'd push run`, and anything else grades on `conclusion`. The same read shape runs over topology.yml and ecosystem.yml (row 12) and excludes `sidekiq release watcher`. test/unit/health_brief_test.rb pins the four properties end-to-end by running the extracted brief cells against a PATH-stubbed `gh`. Dz-Task-Id: tsk_bd3d8324dec61d2dbf7a9465468ec7db
|
wurk rows 8,12: read detect.dup outcome (or graded steps) alongside conclusion
Work landed on #598 — watching it toward merge. 4h15m · 547 tool calls · 253 messages Sessions: coding run 🤖 developerz.ai, an automated agent, not a human — hv-dedicated-reviewer-1 (developerz-ai[bot]) · model |
|
Waiting on our own review of this head, which is taking too long. Nothing is needed from you right now.
Status for head 🤖 Posted by developerz.ai — an automated agent, not a human. |
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 1m 38s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 2 file(s), 0 finding(s).
completed — reviewer[bot]: Adds dup-aware job-list grading to the health brief and five shell-level regression tests. No blocking defects found in the supplied diff.
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-ci-2 — 81.5k in / 1.24k out over 3 calls; cost unknown: no price on record for router/gpt-6.1-sol.
What
A push whose tree already passed on the PR head reports
successwithnothing having run, so rows 8 and 12 of the health brief used to certify
main green on a verdict they could not actually establish. Both rows now
call
gh api .../actions/runs/<id>/jobsand branch on the result: anempty or unparseable list surfaces as
verdict unknown <sha>, asuccessful
detect changed paths+ every gated job skipped surfaces asUnhealthy: <sha> is a dup'd push run, and anything else grades onconclusion. The same read shape runs over topology.yml and ecosystem.yml(row 12) and excludes
sidekiq release watcher. test/unit/health_brief_test.rbpins the four properties end-to-end by running the extracted brief cells
against a PATH-stubbed
gh.Acceptance
gh api .../actions/runs/<id>/jobs; jq separatesdetect changed paths($d) from gated jobs ($g); unreadable list →verdict unknown <sha>beforeconclusionis read.Unhealthy: <sha> is a dup'd push run, but detect=failure + gated=skipped asfailure <sha>(failure is not a dup).sidekiq release watcher), names the offending workflow on the Unhealthy line, grades the healthy lane on its own conclusion + sha.Changes
.dz/briefs/health.md(edit) — Confirm rows 8 and 12 read the jobs API and grade dup'd pushes (detect.succeeded + all gated skipped) asUnhealthy: <sha> is a dup'd push run. Three-step grading: unreadable →verdict unknown <sha>; dup requiresdetect changed paths= success; else grade onconclusion. Restore verbatim if drifted.test/unit/health_brief_test.rb(edit) — Confirm the 5 tests pin rows 8 + 12 against the in-flight brief by running the extracted brief cells as bash (dup'd run → Unhealthy with sha; gated-ran run →success <sha>; unreadable jobs list →verdict unknownnotsuccess; failed detect ≠ dup; row 12 names the offending workflow). Fix any rubocop offense the editor's scoped check surfaces (prior run's gate failed on rubocop).Verification
./bin/checkpassed (exit 0) in 9m 55s.🤖 Opened by developerz.ai for task
tsk_bd3d8324dec61d2dbf7a9465468ec7dbon developerz-ai/wurk.Raised automatically by the
raw_task_triagelane.