Skip to content

wurk rows 8,12: read detect.dup outcome (or graded steps) alongside conclusion - #598

Merged
developerz-ai[bot] merged 1 commit into
mainfrom
dz/wurk-rows-8-12-read-detect-dup-outcome-or-graded--bd3d8324
Oct 21, 2026
Merged

developerz-ai[bot] merged 1 commit into
mainfrom
dz/wurk-rows-8-12-read-detect-dup-outcome-or-graded--bd3d8324

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What

A push whose tree already passed on the PR head reports success with
nothing having run, so rows 8 and 12 of the health brief used to certify
main green on a verdict they could not actually establish. Both rows now
call gh api .../actions/runs/<id>/jobs and branch on the result: an
empty or unparseable list surfaces as verdict unknown <sha>, a
successful detect changed paths + every gated job skipped surfaces as
Unhealthy: <sha> is a dup'd push run, and anything else grades on
conclusion. The same read shape runs over topology.yml and ecosystem.yml
(row 12) and excludes sidekiq release watcher. test/unit/health_brief_test.rb
pins the four properties end-to-end by running the extracted brief cells
against a PATH-stubbed gh.

Acceptance

  • Row 8 invokes gh api .../actions/runs/<id>/jobs; jq separates detect changed paths ($d) from gated jobs ($g); unreadable list → verdict unknown <sha> before conclusion is read.
  • Row 8 grades detect=success + gated=skipped as Unhealthy: <sha> is a dup'd push run, but detect=failure + gated=skipped as failure <sha> (failure is not a dup).
  • Row 12 runs the same read over topology.yml and ecosystem.yml (excluding sidekiq release watcher), names the offending workflow on the Unhealthy line, grades the healthy lane on its own conclusion + sha.
  • bundle exec rubocop test/unit/health_brief_test.rb exits 0.
  • bundle exec ruby -Ilib -Itest test/unit/health_brief_test.rb runs all 5 health tests to completion green, against the in-tree .dz/briefs/health.md (no network, no Redis).

Changes

  • .dz/briefs/health.md (edit) — Confirm rows 8 and 12 read the jobs API and grade dup'd pushes (detect.succeeded + all gated skipped) as Unhealthy: <sha> is a dup'd push run. Three-step grading: unreadable → verdict unknown <sha>; dup requires detect changed paths = success; else grade on conclusion. Restore verbatim if drifted.
  • test/unit/health_brief_test.rb (edit) — Confirm the 5 tests pin rows 8 + 12 against the in-flight brief by running the extracted brief cells as bash (dup'd run → Unhealthy with sha; gated-ran run → success <sha>; unreadable jobs list → verdict unknown not success; failed detect ≠ dup; row 12 names the offending workflow). Fix any rubocop offense the editor's scoped check surfaces (prior run's gate failed on rubocop).

Verification

./bin/check passed (exit 0) in 9m 55s.


🤖 Opened by developerz.ai for task tsk_bd3d8324dec61d2dbf7a9465468ec7db on developerz-ai/wurk.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model MiniMax-M3 on api.minimax.io via native, funded by account_key
Ran on box hv-dedicated-reviewer-1
Cost ~$0.84 for 10.8M in / 84.4k out (estimate: list price x reported tokens, cached input at its cached rate)
Run timeline run_795f5aec04494cde80cf2de5c517988f
Part 1/1 of plan rtk_f5e00b837d3c416aa40854273154443c

A push whose tree already passed on the PR head reports `success` with
nothing having run, so rows 8 and 12 of the health brief used to certify
main green on a verdict they could not actually establish. Both rows now
call `gh api .../actions/runs/<id>/jobs` and branch on the result: an
empty or unparseable list surfaces as `verdict unknown <sha>`, a
successful `detect changed paths` + every gated job skipped surfaces as
`Unhealthy: <sha> is a dup'd push run`, and anything else grades on
`conclusion`. The same read shape runs over topology.yml and ecosystem.yml
(row 12) and excludes `sidekiq release watcher`. test/unit/health_brief_test.rb
pins the four properties end-to-end by running the extracted brief cells
against a PATH-stubbed `gh`.

Dz-Task-Id: tsk_bd3d8324dec61d2dbf7a9465468ec7db
@developerz-ai

developerz-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

wurk rows 8,12: read detect.dup outcome (or graded steps) alongside conclusion

Work landed on #598 — watching it toward merge.

4h15m · 547 tool calls · 253 messages

Sessions: coding run


🤖 developerz.ai, an automated agent, not a human — hv-dedicated-reviewer-1 (developerz-ai[bot]) · model MiniMax-M3 on api.minimax.io

@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by the developerz.ai maintainer bot from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:api.minimax.io developerz.ai: provider that served this bot PR. labels Oct 21, 2026
@developerz-ai

developerz-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Waiting on our own review of this head, which is taking too long. Nothing is needed from you right now.

  • Red on this head: no check is failing
  • What was done: The review task for this head is still running past its wait bound.
  • What happens next: A stuck review is ended and re-run by the platform; the pull request then moves on.

Status for head 38dbacc3990c. This comment is updated in place.

🤖 Posted by developerz.ai — an automated agent, not a human.

@developerz-ai

developerz-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⏱ 1m 38s wall clock · gpt-6.1-sol via router · 3 model call(s) · 1,242 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 2 file(s), 0 finding(s).

completed — reviewer[bot]: Adds dup-aware job-list grading to the health brief and five shell-level regression tests. No blocking defects found in the supplied diff.

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-ci-2 — 81.5k in / 1.24k out over 3 calls; cost unknown: no price on record for router/gpt-6.1-sol.

@developerz-ai
developerz-ai Bot merged commit 073bacf into main Oct 21, 2026
17 checks passed
@developerz-ai
developerz-ai Bot deleted the dz/wurk-rows-8-12-read-detect-dup-outcome-or-graded--bd3d8324 branch October 21, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dz/fleet-pr Opened by the developerz.ai maintainer bot from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:api.minimax.io developerz.ai: provider that served this bot PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants