Repository navigation
Say which Dependabot edits the release window can see - #594
developerz-ai[bot] merged 3 commits into
Conversation
Resolve unmerged conflict markers in .dz/briefs/release-due.md by keeping both intents: base's Pre-flight guard as step 1, window re-check as step 2, prior-run diff's `gh pr list --app dependabot --state merged` form for step 3 (ecosystem-bump conclusions do NOT come from the Decide window; owe `### Changed` only for merged PRs touching `wurk.gemspec`; other ecosystems owe nothing). Cutting a release remains step 4; suffix steps 5 and 6 stay. The Pre-flight guard's inline 'line 127 below' pointer is updated to the resolved line number. Lines 31-35, 97-101, and 103 unchanged. Dz-Task-Id: tsk_ed30fc069bcf0559730f0d3ddcfeaf99
|
Say which Dependabot edits the release window can see
Work landed on #594 — watching it toward merge. 93h22m · 126 tool calls · 29 messages Sessions: coding run · review 1 🤖 developerz.ai, an automated agent, not a human — hv-dedicated-4 (developerz-ai[bot]) · model |
🟡 Reviewed1 actionable comment(s) · grounded on your code ⏱ 1m 15s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 1 file(s), 3 finding(s).
Critical 0 · Major 0 · Minor 3 · Nit 0
completed — Review [bot]: Clarifies Dependabot release-note handling and preserves the pre-flight guard, but date filtering and list truncation can omit eligible bumps, while the empty-window claim contradicts gemspec handling.
No findings from: concern-security.
| File | Findings |
|---|---|
.dz/briefs/release-due.md |
3 minor |
Config notes
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by router/gpt-6.1-sol on box hv-dedicated-ci-0 — 35.2k in / 1.26k out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.
|
A fix round is working on this pull request. Nothing is needed from you right now.
Status for head 🤖 Posted by developerz.ai — an automated agent, not a human. |
Follow-up intent: Address review findings on #594 Dz-Task-Id: tsk_673c8d4ff4497c6cf388fd0eb3ce38dd
There was a problem hiding this comment.
Review summary — 1 file(s), 2 finding(s).
Critical 0 · Major 0 · Minor 2 · Nit 0
completed [bot] — Updates Dependabot release-window discovery and pagination. The filter still admits off-main merges, and the pre-flight prohibition cross-reference is stale.
| File | Findings |
|---|---|
.dz/briefs/release-due.md |
2 minor |
Reviewed the 1 new commit(s) since the last review (58687d1…7a19213). Earlier commits were reviewed on this PR already.
Config notes
- CI checks were not shown to the reviewer — GitHub reported no checks on the commit under review, so this review judged the diff without a build result
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by router/gpt-6.1-sol on box hv-dedicated-5 — 17.3k in / 1.21k out over 1 call; cost unknown: no price on record for router/gpt-6.1-sol.
| keeping each PR whose `.user.login == "dependabot[bot]"` (the account | ||
| `--app dependabot` resolves), `.merged_at != null` and | ||
| `.merged_at >= $last_commit_date` (pass the date as `--arg`; GitHub's | ||
| RFC3339 stamps compare correctly as strings). Note that ecosystem-bump |
There was a problem hiding this comment.
minor · docs [bot] A Dependabot PR merged into another branch after $last_commit_date passes this filter despite being outside $last..main, allowing an unreleased gemspec bump into the changelog. Require merge_commit_sha membership in compare_shas for every candidate, not just those near the date bound.
grounded: .dz/briefs/release-due.md, lib/wurk/lua.rb:238, lib/wurk/lua/loader.rb …
There was a problem hiding this comment.
Re-checked at 9b0c010e0c88: still open at .dz/briefs/release-due.md:145. Completed re-check [bot]: ancestry membership is still required only for candidates near the date bound. The general filter still accepts merged Dependabot PRs by date without requiring merge_commit_sha membership in compare_shas, so PRs merged into another branch can enter the changelog.
…hich-dependabot-edits-the-release-window--ed30fc06 # Conflicts: # .dz/briefs/release-due.md
There was a problem hiding this comment.
Review summary — 1 file(s), 1 finding(s).
Critical 0 · Major 0 · Minor 1 · Nit 0
Completed review [bot]: clarifies which Dependabot changes need release notes and requires exhaustive PR retrieval, but its date-based selection can still include changes outside the release ancestry window.
| File | Findings |
|---|---|
.dz/briefs/release-due.md |
1 minor |
The 4 commit(s) since the last review merged the base branch: this pass read only this pull request's own change, against the base, in the files whose change moved. Code the base brought in was not reviewed here.
Config notes
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by router/gpt-6.1-sol on box hv-dedicated-5 — 51.4k in / 426 out over 3 calls; cost unknown: no price on record for router/gpt-6.1-sol.
| .commit.committer.date`) as `$last_commit_date`. Settle any candidate whose `merged_at` | ||
| sits near that bound by ancestry, not by timestamp — its `merge_commit_sha` must be one | ||
| of the Compare window's `compare_shas` (every commit in `$last..main`, shipping or not). | ||
| List exhaustively — `gh pr list` cannot: it returns its default 30 results and rejects | ||
| `--paginate` (the reason the title guard uses `gh api --paginate`), so the 31st in-window | ||
| Dependabot PR would silently vanish from the changelog. Walk the pulls endpoint instead: | ||
| `gh api --paginate "repos/developerz-ai/wurk/pulls?state=closed&per_page=100"`, keeping | ||
| each PR whose `.user.login == "dependabot[bot]"` (the account `--app dependabot` | ||
| resolves), `.merged_at != null` and `.merged_at >= $last_commit_date` (pass the date as | ||
| `--arg`; GitHub's RFC3339 stamps compare correctly as strings). Note that ecosystem-bump |
There was a problem hiding this comment.
minor · docs [bot] A Dependabot gemspec PR merged into another branch well after $last_commit_date passes this filter without belonging to $last..main, adding an unreleased bump to the changelog. Require merge_commit_sha membership in compare_shas for every candidate rather than checking ancestry only near the date bound.
grounded: .dz/briefs/release-due.md, lib/wurk/lua.rb:238, lib/wurk/lua/loader.rb …
What
Resolve unmerged conflict markers in .dz/briefs/release-due.md by
keeping both intents: base's Pre-flight guard as step 1, window
re-check as step 2, prior-run diff's
gh pr list --app dependabot --state mergedform for step 3 (ecosystem-bump conclusions do NOTcome from the Decide window; owe
### Changedonly for mergedPRs touching
wurk.gemspec; other ecosystems owe nothing). Cuttinga release remains step 4; suffix steps 5 and 6 stay. The Pre-flight
guard's inline 'line 127 below' pointer is updated to the resolved
line number. Lines 31-35, 97-101, and 103 unchanged.
Acceptance
<<<<<<< ours,=======, or>>>>>>> theirsmarkers remain in the filegh pr list --app dependabot --state merged, states ecosystem-bump conclusions do NOT come from the Decide window, and owes### Changedonly for merged PRs touchingwurk.gemspecfrontend/package.json+bun.lock, github-actions, dockerwurk.gemspecand bun'sfrontend/package.json+bun.lockare outside the pathspec, consistent with the seven ship-spec paths at lines 31-35bin/rake test TEST=test/unit/release_due_brief_test.rbpassesChanges
.dz/briefs/release-due.md(edit) — Resolve conflict (lines 119/125/138) in '## The ask, when due': keep base's Pre-flight guard as step 1, window re-check as step 2. Adopt saved-diff'sgh pr list --app dependabot --state mergedcontent as step 3: ecosystem-bump conclusions do NOT come from the Decide window; owe### Changedonly for merged PRs touchingwurk.gemspec; Gemfile dev pins, bun, github-actions, docker owe nothing. Keep Cutting a release as step 4; steps 5/6 stay. Strip markers. Update the Pre-flight guard's inline 'line 127 below' pointer to the resolved line of the prohibition clause.Verification
./bin/checkpassed (exit 0) in 12m 47s.🤖 Opened by developerz.ai for task
tsk_ed30fc069bcf0559730f0d3ddcfeaf99on developerz-ai/wurk.Raised automatically by the
raw_task_triagelane.