Skip to content

fix(render): a locale-prefixed isr page revalidates - #756

Merged
sebyx07 merged 1 commit into
mainfrom
fix/isr-locale-prefixed-revalidation
Oct 10, 2026
Merged

sebyx07 merged 1 commit into
mainfrom
fix/isr-locale-prefixed-revalidation

Conversation

@sebyx07

@sebyx07 sebyx07 commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

routePathOf stripped the query from the ISR key but not the routed locale prefix, so
/en/blog/a matched no route: no ttl, no tag edge, no Surrogate-Key, s-maxage=60. The
entry was fresh forever and a stored 404 never expired. The lookup now uses the same
unlocalized path the router matches; the key keeps its locale. examples/dummy gains an
e2e that publishes a draft and asks the prefixed page to change.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

routePathOf stripped the query from the ISR key but not the routed locale prefix, so
/en/blog/a matched no route: no ttl, no tag edge, no Surrogate-Key, s-maxage=60. The
entry was fresh forever and a stored 404 never expired. The lookup now uses the same
unlocalized path the router matches; the key keeps its locale. examples/dummy gains an
e2e that publishes a draft and asks the prefixed page to change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@developerz-ai

developerz-ai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Review did not complete

developerz.ai started reviewing this pull request and stopped before finishing: the pull request was merged or closed while it ran.

This is a failure of the review run, not a verdict on the changes — nothing here says the diff is good or bad. The run is recorded on this task's audit trail.

⏱ 7m 29s wall clock · MiniMax-M3 via minimax · 2 model call(s) · 27,530 output token(s) · slowest call 3m 06s

🤖 developerz.ai — automated review, running on your box. This run did not complete.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 104 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: developerz-ai/ultimate/.coderabbit.yml
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 33ed3bcb-c5e6-444a-9db1-e1832fa946fb

📥 Commits

Reviewing files that changed from the base of the PR and between 8604f58 and f5ab969.


📒 Files selected for processing (10)
  • CHANGELOG.md
  • examples/dummy/apps/web/e2e/blog-locales.e2e.test.ts
  • packages/cli/src/runtime-render-isr-locale.test.ts
  • packages/render/README.md
  • packages/render/src/render-isr-locale.test.ts
  • packages/render/src/render-isr-store.ts
  • packages/render/src/render-isr.ts
  • wiki/I18n.md
  • wiki/Known-Gaps.md
  • wiki/Routes-And-Render-Modes.md

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sebyx07
sebyx07 merged commit d988260 into main Oct 10, 2026
17 checks passed
@sebyx07
sebyx07 deleted the fix/isr-locale-prefixed-revalidation branch October 10, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant