Repository navigation
fix(entity): an arrayOf(uuid()) column reads on a real Postgres; every column kind round-trips on both drivers - #752
Conversation
…y column kind round-trips on both drivers Bun.SQL returns uuid[] (and arrays of types it has no parser for) as the Postgres array literal; decodeRow handed that string to arrayOf's parser, which refused it (X_INVARIANT_VIOLATED column.array). PGlite parses them, so only a real Postgres showed it: a row with a uuid[] could be written and never read back. - decodeRow reads a declared array column through arrayFromDriver: an Array passes, a typed array becomes one, a string goes through the array-literal grammar and each element through its declared kind. A non-array column is never inspected. - One array-literal reader (parsePgArray), shared with @ultimat3/realtime. - column-matrix: every column kind and an array of every accepted element kind, insert/read/update on Bun.SQL against Postgres (gate live) and on PGlite (unit). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 2m 23s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 2 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This change makes Postgres array columns such as uuid[] decode correctly when Bun.SQL returns them as text literals, and it shares the parser with realtime. No merge-blocking risk was identified in the supplied changes. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 12 files. (5 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the primary fix: reading arrayOf(uuid()) values from real Postgres and validating round trips across both drivers. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
Full details: Docstring Coverage
-
-
Explanation
Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 12 files. (5 skipped: 5 unsupported.)
-
✨ Finishing Touches 💡 1
-
-
📝 Generate docstrings 💡
-
-
-
- Commit to this branch
- Create a new PR
-
-
🧪 Generate unit tests (beta)
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![developerz-ai[bot]](https://avatars.githubusercontent.com/in/3783704?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review summary — 17 file(s), 0 finding(s).
No findings from: pg-array-refactor, entity-docs, concern-security (nothing to review: Adversarial review of the diff against the security concern set: no injection sink added (arrayLiteral/arrayElement writer is unchanged; the new parsePgArray/arrayFromDriver parse driver-returned cells into JS values before the column's $parse, never into SQL), no authn/authz boundary widened, no n…), concern-tests, concern-api-contract.
(Some reviewers completed only 0 of 1 review samples; findings are the union of the samples that completed.)
🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by minimax/MiniMax-M3 on box sebby-ovh-2 — 1.22M in / 252.8k out over 10 calls, ~$0.62 on your key (estimate: list price x reported tokens).
…graph pins follow the two entity modules (measured) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Review summary — 2 file(s), 0 finding(s).
Incremental diff: ceiling raises (+2 each) for two new entity modules and a type-explicit update to the date-array test assertion. Both changes are internally consistent and align with the PR description.
No findings from: concern-security (nothing to review: Both changed files are tests. serve-graph.test.ts only updates module-count pins and their explanatory comments — no behaviour, no input boundary, no privileged operation.), concern-tests (nothing to review: Every behaviour changed by this PR is asserted by a test that would fail on revert. The diff only renames a date[] element to its branded form, which is a typescript-level follow-up with the same runtime check.).
Reviewed the 1 new commit(s) since the last review (27bed25…411ca72). Earlier commits were reviewed on this PR already.
🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by minimax/MiniMax-M3 on box sebby-ovh-1 — 89.8k in / 24.4k out over 3 calls, ~$0.06 on your key (estimate: list price x reported tokens).
1 participant
Bun.SQL returns uuid[] (and arrays of types it has no parser for) as the Postgres
array literal; decodeRow handed that string to arrayOf's parser, which refused it
(X_INVARIANT_VIOLATED column.array). PGlite parses them, so only a real Postgres
showed it: a row with a uuid[] could be written and never read back.
a typed array becomes one, a string goes through the array-literal grammar and
each element through its declared kind. A non-array column is never inspected.
insert/read/update on Bun.SQL against Postgres (gate live) and on PGlite (unit).
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Summary by CodeRabbit