Skip to content

fix(ci): run madge from an isolated install — typescript@7 has no JS API #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebyx07 merged 1 commit into from
Oct 7, 2026
Merged

fix(ci): run madge from an isolated install — typescript@7 has no JS API #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ concurrency:
jobs:
bun:
name: bun (test + lint)
# Blacksmith 2 vCPU runner — fast on small CI matrices, plenty for our test suite.
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).
runs-on: ubuntu-22.04
timeout-minutes: 10
Expand All @@ -30,7 +29,11 @@ jobs:
run: bun run lint

- name: import cycles
run: bunx madge --circular packages/*/src
# madge runs from its own isolated install, never the workspace tree: its TS parser
# (typescript-estree) needs the TypeScript JS API, which typescript@7 no longer ships.
# As a workspace devDep the root `typescript` override forced it onto 7 and it crashed
# with "Cannot read properties of undefined (reading 'Cjs')".
run: bunx madge@8.0.0 --circular packages/*/src

- name: typecheck
run: bun run typecheck
Expand Down
Loading