test: Fix remaining Docker references and validate LXC migration

[sebyx07]

Summary

This PR completes the LXC migration by fixing all remaining Docker references in comments and documentation, and validates that the full test suite passes.

Changes Made

Configuration Updates

• Changed default sandbox type from BACKEND_TYPES.DOCKER to BACKEND_TYPES.INCUS in orchestrator
• Updated ProjectInitializer default sandbox to 'incus' with 'ai-army-base' image instead of 'docker' with 'node:22-slim'

Documentation Updates

• Replaced "Docker container" references with "container" in:
  • bot-manager.js - lifecycle management comments
  • tool-executor.js - tool execution comments
  • bash-tool.js - JSDoc parameters
  • file-tools.js - JSDoc parameters
  • tool-registry.js - JSDoc parameters
• Updated "Docker image" to "container image" in:
  • bot-router.js - config update documentation
  • worker-router.js - API endpoint documentation
  • WorkerCommand.js - CLI command documentation
• Fixed fallback messaging from "Docker management" to "container management" in orchestrator

Architecture Notes

• Updated AGENT.md and README comments in ProjectInitializer to reflect container-based architecture
• Changed test integration comment from "With Docker/DB" to "With containers/DB"

Test Results

✅ All tests pass:

• Lint: ✓ ESLint + Prettier
• Unit tests: 5599/5599 passing
• Integration tests: 618/618 passing
• E2E tests: 0 (skipped - no PostgreSQL in dev)
• Config validation: ✓ npx ai-army validate passes

Validation Checklist

✅ No dangling imports of deleted modules (DockerManager, DockerBackend)
✅ No dockerode in package-lock.json
✅ grep -r "docker" src/ shows only legitimate references:

• docker-compose.yml for master setup
• dockerAccess config field for Docker-in-LXC support
• Comparison comments explaining LXC vs Docker
• docker-internal hostname checks for local DB
• Health router comment about probe types (Docker, Kubernetes, ALB)

Backwards Compatibility

⚠️ No backwards compatibility - As specified in the plan, all Docker backward compat has been removed. Workers must use LXC (Incus backend).

Related Issues

Completes task #19 from .claude-task-master/plan.md - Run full test suite and fix any broken tests.

🤖 Generated with Claude Task Master

Greptile Overview

Greptile Summary

This PR completes the Docker-to-LXC (Incus) migration by updating remaining Docker references in comments and documentation across 10 files, and fixes two substantive code issues:

• Bug fix in orchestrator.js: The default sandbox type fallback previously referenced BACKEND_TYPES.DOCKER, which resolved to undefined since the Docker backend was already removed. Now correctly falls back to BACKEND_TYPES.INCUS.
• Config fix in ProjectInitializer.js: Updated the init template to use type: 'incus' with incusImage: 'ai-army-base' instead of the removed type: 'docker' with image: 'node:22-slim'.
• Comment cleanup: Replaced "Docker container" → "container" and "Docker image" → "container image" across JSDoc and inline comments in bot-manager, tool-executor, bash-tool, file-tools, tool-registry, bot-router, worker-router, and WorkerCommand.

Confidence Score: 5/5

• This PR is safe to merge — it fixes a real bug (undefined fallback) and updates stale documentation references.
• 8 of 10 files contain only comment/JSDoc changes with zero logic impact. The two substantive changes (orchestrator default fallback and ProjectInitializer template) are both clear correctness fixes — the previous code referenced a removed Docker backend type. The PR author reports all tests pass (5599 unit + 618 integration).
• No files require special attention. All changes are straightforward and correct.

Important Files Changed

Filename	Overview
src/core/orchestrator.js	Fixed default sandbox type from BACKEND_TYPES.DOCKER (undefined since Docker was removed) to BACKEND_TYPES.INCUS. Updated fallback log messages from "Docker management" to "container management".
src/cli/ProjectInitializer.js	Updated default sandbox config template from docker/node:22-slim to incus/ai-army-base with correct incusImage field. Updated AGENT.md template comments to reference containers instead of Docker.
src/core/bot-manager.js	Comment-only changes replacing "Docker container" with "container" in JSDoc and inline comments. No logic changes.
src/api/routers/bot-router.js	Comment-only change: updated "Docker image" to "Container image" in PATCH /api/bots/:id/config JSDoc.
src/api/routers/worker-router.js	Comment-only change: updated "Docker image" to "container image" in PUT /api/v1/workers/:id/image JSDoc.
src/cli/WorkerCommand.js	Comment-only changes: updated two JSDoc @PARAM descriptions from "Docker image" to "container image".
src/execution/tool-executor.js	Comment-only change: updated class JSDoc from "Docker containers" to "containers".
src/tools/bash-tool.js	Comment-only changes: updated JSDoc from "Docker container" to "container" in two places.
src/tools/file-tools.js	Comment-only changes: updated JSDoc from "Docker container" to "container" across readFile, writeFile, glob, and grep tool factories (8 replacements).
src/tools/tool-registry.js	Comment-only change: updated JSDoc from "Docker container access" to "container access".

Flowchart

flowchart TD
    A[Project Init / Config Load] -->|sandbox.type| B{Sandbox Type?}
    B -->|"'incus' (default)"| C[BACKEND_TYPES.INCUS]
    B -->|"'just-bash'"| D[BACKEND_TYPES.JUST_BASH]
    C --> E[IncusBackend]
    E -->|reads incusImage| F[Create LXC Container]
    D --> G[JustBashBackend]

    style C fill:#90EE90
    style E fill:#90EE90
    style F fill:#90EE90

Loading

_{Last reviewed commit: 6d3d3fd}

[greptile-apps]

_{10 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{10 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}