Repository navigation
test: Remove Docker tests, add comprehensive Incus coverage - #65
Merged
Merged
Conversation
Confirmed that the following Docker-specific test files do not exist: - test/unit/execution/DockerManager.test.js - test/unit/execution/DockerBackend.test.js - test/integration/execution/DockerManager.test.js These files were already removed or never existed in this branch. Current execution test coverage uses only Incus backend tests. All unit tests pass (5584/5584). Task #14 complete. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Task 15 verification - ContainerPool.test.js already cleaned: - ✅ No "backward compatibility" descriptions - ✅ No createMockDockerManager() factory (only createMockBackend()) - ✅ No Docker backward compat test cases - ✅ No backward compatibility describe blocks - ✅ All tests use mock ContainerBackend instances - ✅ All 68 tests passing The file was already cleaned up in previous commits (PR #58, #62). This commit documents verification of Task 15 completion. Co-Authored-By: Claude <noreply@anthropic.com>
- Remove "Legacy properties kept for backward compatibility" comments from ToolExecutor.test.js, BashTool.test.js, and FileTools.test.js - Add IncusBackend and IncusClient export tests to index.test.js - All other backward compat test removals already completed in previous tasks - ContainerBackend.test.js already correctly validates DOCKER is undefined Co-Authored-By: Claude <noreply@anthropic.com>
Updated test comments and descriptions in E2E test files: - test/e2e/Orchestrator.e2e.test.js: Changed "Docker dependency" to "Incus container dependency", updated mock AgentRunner comment from "Docker-like execution" to "Incus container execution", updated test name from "Docker bash" to "Incus bash" - test/e2e/WorkerDeployment.e2e.test.js: Changed "Docker container" to "Incus container" in lifecycle comments, updated component descriptions to reference Incus, updated test suite name and comments All tests pass (5586 unit + 619 integration + 0 e2e skipped). No backward compatibility - workers use Incus only. Co-Authored-By: Claude <noreply@anthropic.com>
- Enhance IncusBackend tests with coverage for workspace path resolution, user handling edge cases, start timeout behavior, and custom remote images - Enhance IncusClient tests with stdout/stderr log retrieval, async operation error variants, API error fallback messages, and pushFile header validation - Total: 75 IncusBackend tests + 49 IncusClient tests = 124 tests passing Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code
Greptile Overview
Greptile Summary
Completes the Docker-to-Incus migration by removing all Docker references from tests and adding comprehensive test coverage for Incus backend components.
Key changes:
IncusBackend.test.jscovering workspace path resolution, user handling edge cases (root, numeric UIDs, invalid users), start timeout behavior with retries, custom remote image parsing, and container lookup edge casesIncusClient.test.jscovering stdout/stderr log retrieval from exec operations, file push with optional uid/gid/mode headers, and error handling edge cases (missing error fields, non-Failure status with err field)IncusBackendandIncusClientin main index testConfidence Score: 5/5
Important Files Changed
Last reviewed commit: 34c769b