[sebyx07]

Summary

Add comprehensive unit tests for BotManager's Incus sandbox support:

• _hasSandboxChanged() Incus tests: Test detection of changes in incusImage and incusProfile fields
• Sandbox type migration tests: Test transitioning between docker and incus sandbox types
• startBot() Incus test: Verify Incus config is correctly passed to ContainerPool
• reloadBot() Incus tests: Test container recreation when Incus-specific fields change

Test Coverage

• 4 new tests in _hasSandboxChanged() section for Incus-specific fields
• 6 new tests in Incus sandbox support section covering:
  • Config passing to ContainerPool
  • Container recreation on incusImage change
  • Container recreation on incusProfile change
  • Sandbox type migration (docker → incus)
  • Sandbox type migration (incus → docker)
  • No-op when only non-sandbox config changes

Test Results

All 119 BotManager unit tests pass (10 new Incus-related tests added).

Part of PR Group

PR Group: Tool Layer Adaptation & Integration
Branch: claudetm/feat/abstract-tool-execution

This is the final task in the PR group that abstracts tool execution away from Docker specifics and adds Incus support throughout the codebase.

🤖 Generated with Claude Task Master

Greptile Overview

Greptile Summary

This PR completes the Incus sandbox support implementation by adding comprehensive unit tests for BotManager's Incus-related functionality. The PR includes 10 new tests covering Incus-specific sandbox change detection (incusImage and incusProfile fields), sandbox type migration between docker and incus, and proper configuration passing through the ContainerPool.

Key Changes:

• Added 4 tests to _hasSandboxChanged() for Incus fields (incusImage, incusProfile) and type transitions
• Added 6 tests for Incus support in startBot() and reloadBot() covering config passing, container recreation on Incus field changes, and sandbox type migrations
• Updated ContainerPool tests to verify Incus backend creation and the new exec()/getBackend() methods
• Refactored all tool tests (BashTool, FileTools, ToolExecutor) to use the new containerPool.exec() abstraction
• Added destructuredArrayIgnorePattern to eslint config to support the [_botId, ...] pattern in tests
• Added startup logging for available sandbox backends

The implementation correctly mirrors the Docker backend pattern by reusing a shared default IncusBackend instance for local bots (addressing the previous review comment). All 119 tests pass successfully.

Confidence Score: 5/5

• This PR is safe to merge with no risk - it adds comprehensive test coverage without modifying core logic
• All changes are test-focused with minimal production code modifications. The production changes (eslint config update, Incus field checks in _hasSandboxChanged(), incusHost option passing) are simple and well-tested. The previous concern about IncusBackend instantiation has been addressed in a prior commit. Tests are thorough, well-structured, and all 119 tests pass.
• No files require special attention

Important Files Changed

Filename	Overview
src/core/bot-manager.js	Added Incus support: passes incusHost option to ContainerPool and checks incusImage/incusProfile fields in _hasSandboxChanged()
src/execution/container-pool.js	Implemented Incus backend support with shared default instance, added exec() and getBackend() convenience methods
src/execution/tool-executor.js	Refactored to use containerPool.exec() instead of directly accessing dockerManager.exec() for backend abstraction
src/tools/bash-tool.js	Updated to use containerPool.exec() instead of direct dockerManager access
src/tools/file-tools.js	Updated all file tools to use containerPool.exec() instead of direct dockerManager access
test/unit/core/BotManager.test.js	Added 10 new tests for Incus support covering _hasSandboxChanged(), startBot(), reloadBot(), and sandbox type migration
test/unit/execution/ContainerPool.test.js	Updated Incus test expectation and added comprehensive tests for new exec() and getBackend() methods

Sequence Diagram

sequenceDiagram
    participant BM as BotManager
    participant CP as ContainerPool
    participant IB as IncusBackend
    participant DB as DockerBackend
    participant TE as ToolExecutor
    participant BT as BashTool
    
    Note over BM,BT: Incus Support Integration
    
    BM->>CP: startBot(botId, config)<br/>{sandbox.type: 'incus', incusImage: 'ai-army-base'}
    CP->>CP: _getBackend(botId, config, {incusHost})
    alt No incusHost (local)
        CP->>IB: new IncusBackend() [shared instance]
    else With incusHost (remote)
        CP->>IB: new IncusBackend({socketPath: incusHost})
    end
    CP->>IB: createContainer(config)
    IB-->>CP: container
    CP-->>BM: container
    
    Note over TE,BT: Tool Execution Abstraction
    
    BT->>CP: exec(botId, command, options)
    CP->>CP: getContainer(botId)
    CP->>CP: _getBackendForBot(botId)
    alt Incus Backend
        CP->>IB: exec(container, command, options)
        IB-->>CP: {exitCode, stdout, stderr}
    else Docker Backend
        CP->>DB: exec(container, command, options)
        DB-->>CP: {exitCode, stdout, stderr}
    end
    CP-->>BT: result
    
    Note over BM: Sandbox Change Detection
    BM->>BM: _hasSandboxChanged(oldSandbox, newSandbox)
    Note right of BM: Checks incusImage<br/>and incusProfile

Loading

_{Last reviewed commit: 6e96f64}

[greptile-apps]

_{12 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}