fix(xlsx): draw icon-set arrows as Excel's filled shapes#457
Merged
Conversation
developer0hye
force-pushed
the
fix/xlsx-icon-set-glyphs
branch
from
July 25, 2026 10:16
6f1aa7c to
476cb44
Compare
Excel's arrow icon sets are drawn shapes, not characters: a shaft with a triangular head, filled in the band color and outlined a shade darker, about 10 pt tall in a 14 pt row. office2pdf rendered them as triangle characters roughly a third that size. Draw the five arrow bands as Typst polygons at Excel's proportions, with the diagonals rotated 45 degrees. Icon sets that are not arrows — traffic lights, flags, symbols — keep their character rendering. The arrow codepoints move to the IR so the parser and renderer share one vocabulary for the glyph field. Fixes #377 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
force-pushed
the
fix/xlsx-icon-set-glyphs
branch
from
July 25, 2026 10:52
476cb44 to
464bc0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TableCell::icon_text.Related issue
Fixes #377
Testing
cargo test --workspace(1823 tests, all pass)cargo clippy --workspace --all-targets(clean)cargo fmt --checkpdftoppm -r 150on10_kpi_tracker_enpage 1 for all three PDFsAchievementcolumn at 280% scalemagick compare -metric AE -fuzz 5%on the size-normalized pageVisual impact
Visual audit
fixassets/bugfixes/issue-377/gt.jpgassets/bugfixes/issue-377/before.jpgassets/bugfixes/issue-377/after.jpgassets/bugfixes/issue-377/compare.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline